Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2196833002: Propagate proper FROM_HERE to postTask() in worker code (Closed)

Created:
4 years, 4 months ago by tzik
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, kinuko+worker_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, falken, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, Nate Chapin, blink-reviews-wtf_chromium.org, blink-worker-reviews_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Propagate proper FROM_HERE to postTask() in worker code Some of postTask() implementation in Worker code don't have WebTraceLocation parameter, and pass wrong FROM_HEREs. That make it hard to follow the call stack in a crash report. This adds the missing WebTraceLocation parameter, puts correct FROM_HEREs and adds alias() to ensure it's in the crash report. Committed: https://crrev.com/c58cf271a13e03259fe3e6ed5c200041b25a703c Cr-Commit-Position: refs/heads/master@{#408886}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -107 lines) Patch
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 4 chunks +24 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h View 3 chunks +17 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 8 chunks +38 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerLoaderProxy.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 13 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/wtf/debug/Alias.h View 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/debug/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
tzik
PTAL
4 years, 4 months ago (2016-07-29 19:48:57 UTC) #10
haraken
LGTM
4 years, 4 months ago (2016-07-29 21:28:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196833002/20001
4 years, 4 months ago (2016-07-31 11:30:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/199447) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-07-31 11:32:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196833002/40001
4 years, 4 months ago (2016-07-31 15:21:09 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-31 16:28:12 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-07-31 16:30:11 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c58cf271a13e03259fe3e6ed5c200041b25a703c
Cr-Commit-Position: refs/heads/master@{#408886}

Powered by Google App Engine
This is Rietveld 408576698