Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: runtime/vm/service.cc

Issue 2196723002: Refactor how we report reload results (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweak Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_reload.cc ('k') | runtime/vm/unit_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 8ef6e8945abac5c1c7ade1623371734315fd2a2c..c57890a6b0404b44a1e447cfeb2be8747eee10b6 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2493,18 +2493,8 @@ static bool ReloadSources(Thread* thread, JSONStream* js) {
const bool force_reload =
BoolParameter::Parse(js->LookupParam("force"), false);
- isolate->ReloadSources(force_reload);
+ isolate->ReloadSources(js, force_reload);
- const Error& error = Error::Handle(isolate->sticky_reload_error());
-
- if (error.IsNull()) {
- PrintSuccess(js);
- } else {
- // Clear the sticky error.
- isolate->clear_sticky_reload_error();
- js->PrintError(kIsolateReloadFailed,
- "Isolate reload failed: %s", error.ToErrorCString());
- }
return true;
}
« no previous file with comments | « runtime/vm/object_reload.cc ('k') | runtime/vm/unit_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698