runtime/vm/unit_test.cc - Issue 2196723002: Refactor how we report reload results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/unit_test.cc

Issue 2196723002: Refactor how we report reload results (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: wip Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/unit_test.cc

diff --git a/runtime/vm/unit_test.cc b/runtime/vm/unit_test.cc

index 9c89d9c7d8bde2be03b5d08a71fa437a2bbb370c..728c8f93350d48cc9b1106b4f31880d0a475224b 100644

--- a/runtime/vm/unit_test.cc

+++ b/runtime/vm/unit_test.cc

@@ -280,10 +280,12 @@ void TestCase::SetReloadTestScript(const char* script) {

Dart_Handle TestCase::TriggerReload() {

Isolate* isolate = Isolate::Current();

+ JSONStream js;

{

TransitionNativeToVM transition(Thread::Current());

- isolate->ReloadSources(false, // force_reload

+ isolate->ReloadSources(&js,

+ false, // force_reload

true); // dont_delete_reload_context

}

turnidge 2016/08/01 17:24:25 Perhaps we should dump the json stream here in som

« runtime/vm/isolate_reload.cc ('K') | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »