Refactor how we report reload results

runtime/vm/isolate_reload.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate_reload.h"
 
 #include "vm/become.h"
 #include "vm/bit_vector.h"
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
@@ skipping 149 matching lines @@
   THR_Print("Morphing from ");
   DumpFormatFor(from_);
   THR_Print("To ");
   DumpFormatFor(to_);
   THR_Print("\n");
 }
 
 
 void InstanceMorpher::AppendTo(JSONArray* array) {
   JSONObject jsobj(array);
-  jsobj.AddProperty("type", "Morpher");
+  jsobj.AddProperty("type", "ShapeChangeMapping");
   jsobj.AddProperty("class", to_);
-  jsobj.AddProperty("instances", before()->length());
-  JSONArray map(&jsobj, "mapping");
+  jsobj.AddProperty("instanceCount", before()->length());
+  JSONArray map(&jsobj, "fieldOffsetMappings");
   for (int i = 0; i < mapping_.length(); i += 2) {
     JSONArray pair(&map);
     pair.AddValue(mapping_.At(i));
     pair.AddValue(mapping_.At(i+1));
   }
 }
 
 
 void ReasonForCancelling::Report(IsolateReloadContext* context) {
   const Error& error = Error::Handle(ToError());
@@ skipping 23 matching lines @@
 
 
 void ClassReasonForCancelling::AppendTo(JSONArray* array) {
   JSONObject jsobj(array);
   jsobj.AddProperty("type", "ReasonForCancelling");
   jsobj.AddProperty("class", from_);
   const String& message = String::Handle(ToString());
   jsobj.AddProperty("message", message);
 }
 
+
 RawError* IsolateReloadContext::error() const {
   ASSERT(has_error());
   // Report the first error to the surroundings.
   const Error& error =
       Error::Handle(reasons_to_cancel_reload_.At(0)->ToError());
-  OS::Print("[[%s]]\n", error.ToCString());
   return error.raw();
 }
 
 
 class ScriptUrlSetTraits {
  public:
   static bool ReportStats() { return false; }
   static const char* Name() { return "ScriptUrlSetTraits"; }
 
   static bool IsMatch(const Object& a, const Object& b) {
@@ skipping 117 matching lines @@
 bool IsolateReloadContext::IsSameLibrary(
     const Library& a_lib, const Library& b_lib) {
   const String& a_lib_url =
       String::Handle(a_lib.IsNull() ? String::null() : a_lib.url());
   const String& b_lib_url =
       String::Handle(b_lib.IsNull() ? String::null() : b_lib.url());
   return a_lib_url.Equals(b_lib_url);
 }
 
 
-IsolateReloadContext::IsolateReloadContext(Isolate* isolate)
+IsolateReloadContext::IsolateReloadContext(Isolate* isolate,
+                                           JSONStream* js)
     : start_time_micros_(OS::GetCurrentMonotonicMicros()),
       reload_timestamp_(OS::GetCurrentTimeMillis()),
       isolate_(isolate),
       reload_skipped_(false),
+      js_(js),
       saved_num_cids_(-1),
       saved_class_table_(NULL),
       num_saved_libs_(-1),
       instance_morphers_(),
       reasons_to_cancel_reload_(),
       cid_mapper_(),
       modified_libs_(NULL),
       script_uri_(String::null()),
       error_(Error::null()),
       old_classes_set_storage_(Array::null()),
@@ skipping 159 matching lines @@
   // information from scratch.
   RebuildDirectSubclasses();
 
   if (FLAG_write_protect_code) {
     // Re-enable code page write protection.
     I->heap()->WriteProtectCode(true);
   }
 
   BackgroundCompiler::Enable();
 
-  if (FLAG_trace_reload) {
-    JSONStream stream;
-    ReportOnJSON(&stream);
-    OS::Print("\nJSON report:\n  %s\n", stream.ToCString());
-  }
+  ReportOnJSON(js_);
 }
 
 
 void IsolateReloadContext::ReportOnJSON(JSONStream* stream) {
   JSONObject jsobj(stream);
-  jsobj.AddProperty("type", "Reload");
-  jsobj.AddProperty("succeeded", !HasReasonsForCancelling());
-  if (HasReasonsForCancelling()) {
-    JSONArray array(&jsobj, "reasons");
-    for (intptr_t i = 0; i < reasons_to_cancel_reload_.length(); i++) {
-      ReasonForCancelling* reason = reasons_to_cancel_reload_.At(i);
-      reason->AppendTo(&array);
-    }
-  } else {
-    JSONArray array(&jsobj, "changes");
-    for (intptr_t i = 0; i < instance_morphers_.length(); i++) {
-      instance_morphers_.At(i)->AppendTo(&array);
+  jsobj.AddProperty("type", "ReloadReport");
+  jsobj.AddProperty("success", !HasReasonsForCancelling());
+  {
+    JSONObject details(&jsobj, "details");
+    if (HasReasonsForCancelling()) {
+      // Reload was rejected.
+      JSONArray array(&jsobj, "notices");
+      for (intptr_t i = 0; i < reasons_to_cancel_reload_.length(); i++) {
+        ReasonForCancelling* reason = reasons_to_cancel_reload_.At(i);
+        reason->AppendTo(&array);
+      }
+    } else {
+      // Reload was successful.
+      const GrowableObjectArray& libs =
+          GrowableObjectArray::Handle(object_store()->libraries());
+      const intptr_t final_library_count = libs.Length();
+      const intptr_t loaded_library_count =
+          final_library_count - num_saved_libs_;
+      details.AddProperty("savedLibraryCount", num_saved_libs_);
+      details.AddProperty("loadedLibraryCount", loaded_library_count);
+      details.AddProperty("finalLibraryCount", final_library_count);
+      JSONArray array(&jsobj, "shapeChangeMappings");
+      for (intptr_t i = 0; i < instance_morphers_.length(); i++) {
+        instance_morphers_.At(i)->AppendTo(&array);
+      }
     }
   }
 }
 
 
 void IsolateReloadContext::AbortReload(const Error& error) {
   AddReasonForCancelling(new Aborted(error));
   ReportReasonsForCancelling();
   Rollback();
 }
@@ skipping 999 matching lines @@
         ASSERT(!super_cls.IsNull());
         super_cls.AddDirectSubclass(cls);
       }
     }
   }
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart