UpdateWindowTitle before SetInitialBounds in Widget::Init.

UpdateWindowTitle before SetInitialBounds in Widget::Init.

Reverse the ordering of these Widget::Init operations.
BubbleFrameView uses title/close presence for sizing.
(requires title/close to be set before bounds init)

DialogDelegate::CreateNewStyleFrameView did this explicitly.
(that changed in http://crrev.com/214637, seems less hacky)

Add a unit test, and cleanup a related test.

BUG=267343
TEST=Dialogs are sized properly, especially non-tab/content-modal dialogs (add wifi, import lock, screen sharing, etc.); see the bug and its dups for examples.
R=sky@chromium.org,ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215805

[msw, 2013-08-02 22:12:20]

Hey Ben and Scott, please take a look; thanks!
I think ordering UpdateWindowTitle nearer to the other |non_client_view_|
initialization makes sense, but it might seem arbitrary to some readers, let me
know if you think this deserves a comment.

[sky, 2013-08-05 16:34:11]

Please add a comment describing UpdateWindowTitle() needs to be before setting
bounds as well as a test.

[msw, 2013-08-05 23:11:41]

On 2013/08/05 16:34:11, sky wrote:
> Please add a comment describing UpdateWindowTitle() needs to be before setting
> bounds as well as a test.

Done; please take another look.

[sky, 2013-08-06 00:03:40]

LGTM - it would be nice to have a test that doesn't depend upon the new style,
but I'm ok with this.

[msw, 2013-08-06 00:12:59]

On 2013/08/06 00:03:40, sky wrote:
> LGTM - it would be nice to have a test that doesn't depend upon the new style,
> but I'm ok with this.

Unfortunately the old style's frame has the same size regardless of the title
presence. I could check that the title is set in a new
TestBubbleFrameView::GetPreferredSize subclass override, but I thought that
seemed a bit overkill. Would you like me to try that or some other approach?

[commit-bot: I haz the power, 2013-08-06 00:38:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/21967002/27001

[commit-bot: I haz the power, 2013-08-06 05:46:27]

Change committed as 215805

[sky, 2013-08-06 14:21:36]

I was thinking more of a test that didn't rely on frame style at all.
By that I mean a test that created custom views and overrode
GetPreferredSize based on title.

On Mon, Aug 5, 2013 at 5:12 PM,  <msw@chromium.org> wrote:
> On 2013/08/06 00:03:40, sky wrote:
>>
>> LGTM - it would be nice to have a test that doesn't depend upon the new
>> style,
>> but I'm ok with this.
>
>
> Unfortunately the old style's frame has the same size regardless of the
> title
> presence. I could check that the title is set in a new
> TestBubbleFrameView::GetPreferredSize subclass override, but I thought that
> seemed a bit overkill. Would you like me to try that or some other approach?
>
> https://codereview.chromium.org/21967002/