Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/compiler/effect-control-linearizer.cc

Issue 2196653002: [turbofan] Introduce a dedicated CheckMaps simplified operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@TurboFan_JSNativeContextSpecialization_NonElementKeyedAccess
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/effect-control-linearizer.cc
diff --git a/src/compiler/effect-control-linearizer.cc b/src/compiler/effect-control-linearizer.cc
index e1c8a45072615cc099bb08f3a8de7a65fc66c541..575f050601f36c947a747efe6ef8c5b9417932fc 100644
--- a/src/compiler/effect-control-linearizer.cc
+++ b/src/compiler/effect-control-linearizer.cc
@@ -622,6 +622,9 @@ bool EffectControlLinearizer::TryWireInStateEffect(Node* node,
case IrOpcode::kCheckBounds:
state = LowerCheckBounds(node, frame_state, *effect, *control);
break;
+ case IrOpcode::kCheckMaps:
+ state = LowerCheckMaps(node, frame_state, *effect, *control);
+ break;
case IrOpcode::kCheckNumber:
state = LowerCheckNumber(node, frame_state, *effect, *control);
break;
@@ -1023,6 +1026,43 @@ EffectControlLinearizer::LowerCheckBounds(Node* node, Node* frame_state,
}
EffectControlLinearizer::ValueEffectControl
+EffectControlLinearizer::LowerCheckMaps(Node* node, Node* frame_state,
+ Node* effect, Node* control) {
+ Node* value = node->InputAt(0);
+
+ // Load the current map of the {value}.
+ Node* value_map = effect = graph()->NewNode(
+ simplified()->LoadField(AccessBuilder::ForMap()), value, effect, control);
+
+ int const map_count = node->op()->ValueInputCount() - 1;
+ Node** controls = temp_zone()->NewArray<Node*>(map_count);
+ Node** effects = temp_zone()->NewArray<Node*>(map_count + 1);
+
+ for (int i = 0; i < map_count; ++i) {
+ Node* map = node->InputAt(1 + i);
+
+ Node* check = graph()->NewNode(machine()->WordEqual(), value_map, map);
+ if (i == map_count - 1) {
+ controls[i] = effects[i] = graph()->NewNode(
+ common()->DeoptimizeUnless(DeoptimizeReason::kWrongMap), check,
+ frame_state, effect, control);
+ } else {
+ control = graph()->NewNode(common()->Branch(), check, control);
+ controls[i] = graph()->NewNode(common()->IfTrue(), control);
+ control = graph()->NewNode(common()->IfFalse(), control);
+ effects[i] = effect;
+ }
+ }
+
+ control = graph()->NewNode(common()->Merge(map_count), map_count, controls);
+ effects[map_count] = control;
+ effect =
+ graph()->NewNode(common()->EffectPhi(map_count), map_count + 1, effects);
+
+ return ValueEffectControl(value, effect, control);
+}
+
+EffectControlLinearizer::ValueEffectControl
EffectControlLinearizer::LowerCheckNumber(Node* node, Node* frame_state,
Node* effect, Node* control) {
Node* value = node->InputAt(0);

Powered by Google App Engine
This is Rietveld 408576698