Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2196643002: Forgot to hook up the ExternalOneByteStringUtf16CharacterStream to lazy parsing (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
vogelheim, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Forgot to hook up the ExternalOneByteStringUtf16CharacterStream to lazy parsing BUG=v8:5215 R=vogelheim@chromium.org,marja@chromium.org Committed: https://crrev.com/0e48f4b37d52a8f4b27771ce363511ab59d28850 Cr-Commit-Position: refs/heads/master@{#38157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/parsing/parser.cc View 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-07-29 07:14:10 UTC) #1
vogelheim
lgtm
4 years, 4 months ago (2016-07-29 07:31:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196643002/1
4 years, 4 months ago (2016-07-29 07:32:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 07:35:52 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 07:39:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e48f4b37d52a8f4b27771ce363511ab59d28850
Cr-Commit-Position: refs/heads/master@{#38157}

Powered by Google App Engine
This is Rietveld 408576698