content/test/data/service_worker/disable_web_security_unregister.html - Issue 2196633002: [ServiceWorker] Don't check the origin equality when disable-web-security flag is set.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/service_worker/disable_web_security_unregister.html

Issue 2196633002: [ServiceWorker] Don't check the origin equality when disable-web-security flag is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add browser_tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/service_worker/service_worker_dispatcher_host.cc ('K') | « content/test/data/service_worker/disable_web_security_register.html ('k') | content/test/data/service_worker/disable_web_security_update.html » ('j') | content/test/data/service_worker/disable_web_security_update.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script>

	4 var iframe = document.createElement('iframe');

	5 iframe.onload = (_ => {
	nhiroki 2016/08/01 04:32:45 Can you verify iframe is on a different origin fro Can you verify iframe is on a different origin from parent frame's origin? For example, if (iframe.location.origin == document.location.origin) { document.title = "FAIL"; return; } horo 2016/08/01 07:40:55 Done. Show quoted text On 2016/08/01 04:32:45, nhiroki wrote: > Can you verify iframe is on a different origin from parent frame's origin? For > example, > > if (iframe.location.origin == document.location.origin) { > document.title = "FAIL"; > return; > } Done.
	6 iframe.contentWindow.navigator.serviceWorker.ready

	7 .then(reg => reg.unregister() )
	shimazu 2016/08/01 05:06:20 +2 indent? # There seems to be two types of codin +2 indent? # There seems to be two types of coding style in this directory... which is correct? = Type 1 = func() .then(function() { return; }) = Type 2 = func().then(function() { return; }) shimazu 2016/08/01 05:06:20 Extra space before the last ')' Extra space before the last ')' horo 2016/08/01 07:40:56 Done. Show quoted text On 2016/08/01 05:06:20, shimazu wrote: > Extra space before the last ')' Done. horo 2016/08/01 07:40:56 Done. We use type 2. See http://www.chromium.org/b Show quoted text On 2016/08/01 05:06:20, shimazu wrote: > +2 indent? > > # There seems to be two types of coding style in this directory... which is > correct? > > = Type 1 = > func() > .then(function() { > return; > }) > > = Type 2 = > func().then(function() { > return; > }) Done. We use type 2. See http://www.chromium.org/blink/serviceworker/testing
	8 .then(_ => { document.title = "PASS"; })

	9 });

	10 iframe.src = location.search.substring(1);

	11 document.body.appendChild(iframe);

	12 </script>

	13 </body>

OLD	NEW