Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Issue 2196623004: Add basic Machine Provider UI (Closed)

Created:
4 years, 4 months ago by smut
Modified:
4 years, 4 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://github.com/luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -2 lines) Patch
M appengine/machine_provider/app.yaml View 1 chunk +6 lines, -0 lines 0 comments Download
M appengine/machine_provider/handlers_cron.py View 1 chunk +1 line, -1 line 0 comments Download
A appengine/machine_provider/handlers_frontend.py View 1 1 chunk +96 lines, -0 lines 0 comments Download
M appengine/machine_provider/main.py View 1 chunk +4 lines, -1 line 0 comments Download
M appengine/machine_provider/models.py View 3 chunks +7 lines, -0 lines 0 comments Download
A appengine/machine_provider/static/style.css View 1 chunk +54 lines, -0 lines 0 comments Download
A appengine/machine_provider/templates/base.html View 1 chunk +19 lines, -0 lines 0 comments Download
A appengine/machine_provider/templates/catalog.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A appengine/machine_provider/templates/leases.html View 1 chunk +43 lines, -0 lines 0 comments Download
A appengine/machine_provider/templates/root.html View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
smut
This adds a basic UI. No functionality for admins yet (i.e. no buttons to click), ...
4 years, 4 months ago (2016-07-29 22:45:56 UTC) #3
M-A Ruel
lgtm https://codereview.chromium.org/2196623004/diff/20001/appengine/machine_provider/models.py File appengine/machine_provider/models.py (right): https://codereview.chromium.org/2196623004/diff/20001/appengine/machine_provider/models.py#newcode43 appengine/machine_provider/models.py:43: last_modified_ts = ndb.DateTimeProperty(auto_now=True) FYI only. auto_now is impossible ...
4 years, 4 months ago (2016-07-30 01:41:59 UTC) #4
smut
https://codereview.chromium.org/2196623004/diff/20001/appengine/machine_provider/models.py File appengine/machine_provider/models.py (right): https://codereview.chromium.org/2196623004/diff/20001/appengine/machine_provider/models.py#newcode43 appengine/machine_provider/models.py:43: last_modified_ts = ndb.DateTimeProperty(auto_now=True) On 2016/07/30 01:41:58, M-A Ruel wrote: ...
4 years, 4 months ago (2016-08-02 23:26:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196623004/40001
4 years, 4 months ago (2016-08-02 23:26:43 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 23:29:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-py/commit/2905a66d9a8074fcbccad1317af66c2665a7fd83

Powered by Google App Engine
This is Rietveld 408576698