Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2196613003: MD Settings: Remove unnecessary scrollbar from Sign out dialog. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Remove unnecessary scrollbar from Sign out dialog. BUG=632575 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b0d782e72062872102fcb7f4a2fc71c5c625cd0b Cr-Commit-Position: refs/heads/master@{#408842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dpapad
Screenshot at http://imgur.com/a/gIUXs. This fixes the scrollbar issue and at the same time adds greater ...
4 years, 4 months ago (2016-07-30 00:00:23 UTC) #3
Dan Beam
in the words of Confucius, after 1h of debugging: "Fuck CSS, lgtm"
4 years, 4 months ago (2016-07-30 00:04:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196613003/1
4 years, 4 months ago (2016-07-30 00:06:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/264907)
4 years, 4 months ago (2016-07-30 01:03:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196613003/1
4 years, 4 months ago (2016-07-30 01:19:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 02:15:06 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 02:17:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0d782e72062872102fcb7f4a2fc71c5c625cd0b
Cr-Commit-Position: refs/heads/master@{#408842}

Powered by Google App Engine
This is Rietveld 408576698