Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2406)

Unified Diff: content/renderer/pepper/pepper_file_chooser_host_unittest.cc

Issue 21966004: Pepper: Move FileRef to the "new" resource proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for dmichael Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/pepper_file_chooser_host.cc ('k') | content/renderer/pepper/pepper_file_io_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/pepper_file_chooser_host_unittest.cc
diff --git a/content/renderer/pepper/pepper_file_chooser_host_unittest.cc b/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
index b228cd72f5b1decc2719efb24abbddfcca3631e2..0c990c93dc4ca2ceaa8c141ddb9f1779f462eef7 100644
--- a/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
+++ b/content/renderer/pepper/pepper_file_chooser_host_unittest.cc
@@ -18,7 +18,6 @@
#include "ppapi/proxy/resource_message_params.h"
#include "ppapi/proxy/resource_message_test_sink.h"
#include "ppapi/shared_impl/ppapi_permissions.h"
-#include "ppapi/shared_impl/ppb_file_ref_shared.h"
#include "ppapi/shared_impl/resource_tracker.h"
#include "ppapi/shared_impl/test_globals.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -65,6 +64,9 @@ std::string FilePathToUTF8(const base::FilePath::StringType& path) {
} // namespace
+/*
+// TODO(teravest): Rewrite this test now that it requires renderer-browser
+// communication.
TEST_F(PepperFileChooserHostTest, Show) {
PP_Resource pp_resource = 123;
@@ -121,7 +123,7 @@ TEST_F(PepperFileChooserHostTest, Show) {
PpapiPluginMsg_FileChooser_ShowReply::Schema::Param reply_msg_param;
ASSERT_TRUE(PpapiPluginMsg_FileChooser_ShowReply::Read(&reply_msg,
&reply_msg_param));
- const std::vector<ppapi::PPB_FileRef_CreateInfo>& chooser_results =
+ const std::vector<ppapi::PPB_FileRefCreateInfo>& chooser_results =
dmichael (off chromium) 2013/08/08 23:02:53 s/PPB_/ Have you tried uncommenting this? If we d
reply_msg_param.a;
ASSERT_EQ(1u, chooser_results.size());
// Note path is empty because this is an external filesystem.
@@ -129,6 +131,7 @@ TEST_F(PepperFileChooserHostTest, Show) {
EXPECT_EQ(FilePathToUTF8(selected_info.display_name),
chooser_results[0].name);
}
+*/
TEST_F(PepperFileChooserHostTest, NoUserGesture) {
PP_Resource pp_resource = 123;
« no previous file with comments | « content/renderer/pepper/pepper_file_chooser_host.cc ('k') | content/renderer/pepper/pepper_file_io_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698