Pepper: Move FileRef to the "new" resource proxy.

ppapi/shared_impl/file_ref_create_info.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_SHARED_IMPL_FILE_REF_CREATE_INFO_H
 #define PPAPI_SHARED_IMPL_FILE_REF_CREATE_INFO_H
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "ppapi/c/pp_file_info.h"
 #include "ppapi/c/pp_resource.h"
+#include "ppapi/shared_impl/ppapi_shared_export.h"
 
 namespace ppapi {
 
 // FileRefs are created in a number of places and they include a number of
 // return values. This struct encapsulates everything in one place.
-struct FileRef_CreateInfo {
+struct FileRefCreateInfo {
+  FileRefCreateInfo() : file_system_type(PP_FILESYSTEMTYPE_INVALID),
+                        browser_pending_host_resource_id(0),
+                        renderer_pending_host_resource_id(0),
+                        file_system_plugin_resource(0) { }
+
+  PPAPI_SHARED_EXPORT bool IsValid() const;
+
   PP_FileSystemType file_system_type;
   std::string internal_path;
   std::string display_name;
 
   // Used when a FileRef is created in the Renderer.
-  int pending_host_resource_id;
+  int browser_pending_host_resource_id;
+  int renderer_pending_host_resource_id;
 
   // Since FileRef needs to hold a FileSystem reference, we need to pass the
-  // resource in this CreateInfo.
+  // resource in this CreateInfo. This struct doesn't hold any refrence on the
+  // file_system_plugin_resource.
   PP_Resource file_system_plugin_resource;
 };
 
+// Used in the renderer when sending a FileRefCreateInfo to a plugin for a
+// FileRef on an external filesystem.
+PPAPI_SHARED_EXPORT FileRefCreateInfo
+MakeExternalFileRefCreateInfo(const base::FilePath& external_path,
+                              const std::string& display_name,
+                              int browser_pending_host_resource_id,
+                              int renderer_pending_host_resource_id);

[dmichael (off chromium), 2013/09/04 17:23:54]

completely optional suggestion: It could be easy to mix up browser and renderer,
since they're the same type. You could make a silly little type to combine them
in one parameter:
class PendingHostIds {
 public:
  PendingHostIds();
  PendingHostIds& set_browser(int browser);
  PendingHostIds& set_renderer(int renderer);
 private:
  int browser;
  int renderer;
};
Just to keep this API self-documenting and safer (if a little more verbose).
Used like this:
MakeExternalFileRefCreateInfo(external_path, display_name,
PendingHostIds().set_browser(browser).set_renderer(renderer));

... or whatever. Lots of ways to do this, some simpler.

+
 }  // namespace ppapi
 
 #endif  // PPAPI_SHARED_IMPL_FILE_REF_CREATE_INFO_H