Pepper: Move FileRef to the "new" resource proxy.

content/renderer/pepper/pepper_file_ref_renderer_host.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_PEPPER_PEPPER_FILE_REF_RENDERER_HOST_H_
+#define CONTENT_RENDERER_PEPPER_PEPPER_FILE_REF_RENDERER_HOST_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/files/file_path.h"
+#include "base/memory/weak_ptr.h"
+#include "content/public/renderer/renderer_ppapi_host.h"
+#include "content/renderer/pepper/pepper_file_system_host.h"
+#include "ipc/ipc_message.h"
+#include "ppapi/c/pp_file_info.h"
+#include "ppapi/c/pp_instance.h"
+#include "ppapi/c/pp_resource.h"
+#include "ppapi/host/host_message_context.h"
+#include "ppapi/host/resource_host.h"
+
+namespace content {
+
+class PepperFileRefRendererHost
+    : public ppapi::host::ResourceHost,
+      public base::SupportsWeakPtr<PepperFileRefRendererHost> {

[dmichael (off chromium), 2013/09/03 22:34:50]

I don't see you using SupportsWeakPtr for this class...  did I miss it? If you
don't need weak ptrs, please remove. If you do need weak ptrs, but can get by
with WeakPtrFactory, please use that instead.

[teravest, 2013/09/04 14:46:25]

Removed.

+ public:
+  PepperFileRefRendererHost(RendererPpapiHost* host,
+                            PP_Instance instance,
+                            PP_Resource resource,
+                            PP_Resource file_system,
+                            const std::string& internal_path);
+
+  PepperFileRefRendererHost(RendererPpapiHost* host,
+                            PP_Instance instance,
+                            PP_Resource resource,
+                            const base::FilePath& external_path);
+
+  virtual ~PepperFileRefRendererHost();
+
+  PP_FileSystemType GetFileSystemType() const;
+  std::string GetFileSystemURLSpec() const;
+  base::FilePath GetExternalFilePath() const;
+
+  // ppapi::host::ResourceHost override.
+  virtual int32_t OnResourceMessageReceived(

[dmichael (off chromium), 2013/09/03 22:34:50]

nit: this and IsFileRefHost could be private

[teravest, 2013/09/04 14:46:25]

I guess it's legal C++, but it seems weird; why bother making these private?

Regardless, this matches the style of other resource hosts. If you'd like, I can
make another patch to make "OnResourceMessageReceived" and "Is...Host" private
in derived classes throughout, though I don't see much benefit.

[dmichael (off chromium), 2013/09/04 17:23:54]

Okay, if this matches our other Resource hosts, that's fine. I make almost
everything private I can...  I subscribe to the philosophy of darin in this
thread:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/CwzjcWd9cYM/TcUUl...
But I don't think it's consistent across the project.

+      const IPC::Message& msg,
+      ppapi::host::HostMessageContext* context) OVERRIDE;
+  virtual bool IsFileRefHost() OVERRIDE;
+
+ private:
+  PP_FileSystemType file_system_type_;
+  std::string internal_path_;
+  base::FilePath external_path_;
+  base::WeakPtr<PepperFileSystemHost> fs_host_;
+
+  DISALLOW_COPY_AND_ASSIGN(PepperFileRefRendererHost);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_RENDERER_PEPPER_PEPPER_FILE_REF_RENDERER_HOST_H_