Pepper: Move FileRef to the "new" resource proxy.

ppapi/shared_impl/file_ref_create_info.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_SHARED_IMPL_FILE_REF_CREATE_INFO_H
 #define PPAPI_SHARED_IMPL_FILE_REF_CREATE_INFO_H
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "ppapi/c/pp_file_info.h"
 #include "ppapi/c/pp_resource.h"
+#include "ppapi/shared_impl/ppapi_shared_export.h"
 
 namespace ppapi {
 
 // FileRefs are created in a number of places and they include a number of
 // return values. This struct encapsulates everything in one place.
-struct FileRef_CreateInfo {
+struct FileRefCreateInfo {
+  FileRefCreateInfo() :
+    file_system_type(PP_FILESYSTEMTYPE_INVALID),

[yzshen1, 2013/08/08 23:16:21]

wrong indent.

[teravest, 2013/08/09 02:00:08]

Done.

+    pending_host_resource_id(0),
+    file_system_plugin_resource(0) { }
+
+  PPAPI_SHARED_EXPORT bool IsValid() const;

[yzshen1, 2013/08/08 23:16:21]

Out of curiosity: why putting PPAPI_SHARED_EXPORT here instead of on the struct
itself?

[teravest, 2013/08/09 02:00:08]

I figured I'd put it minimally per-method; that was the style I've seen
elsewhere.

+
   PP_FileSystemType file_system_type;
   std::string internal_path;
   std::string display_name;
 
   // Used when a FileRef is created in the Renderer.
   int pending_host_resource_id;
 
   // Since FileRef needs to hold a FileSystem reference, we need to pass the

[yzshen1, 2013/08/08 23:16:21]

Please comment on whether this struct holds 1 ref to the resource.
(I guess it doesn't, right?)

[teravest, 2013/08/09 02:00:08]

Done.

   // resource in this CreateInfo.
   PP_Resource file_system_plugin_resource;
 };
 
+// Used in the renderer when sending a FileRefCreateInfo to a plugin for a
+// FileRef on an external filesystem.
+PPAPI_SHARED_EXPORT FileRefCreateInfo
+MakeExternalFileRefCreateInfo(const base::FilePath& external_path,

[yzshen1, 2013/08/08 23:16:21]

Maybe it is better to make it a static function of FileRefCreateInfo?

[teravest, 2013/08/09 02:00:08]

What would the benefit be?

[yzshen1, 2013/08/09 17:11:23]

(I don't think it is very important, though.)

The struct/class provides a better namespace, we usually do:
---------------------------------
class A {
...
  static A* Create(...);
};
---------------------------------
Instead of:
---------------------------------
class A {
};

A* CreateA(...)
---------------------------------

On 2013/08/09 02:00:08, teravest wrote:

+                              const std::string& display_name,
+                              int pending_host_resource_id);
+
 }  // namespace ppapi
 
 #endif  // PPAPI_SHARED_IMPL_FILE_REF_CREATE_INFO_H