Add tests for InputDeviceServer/InputDeviceClient.

Add tests for InputDeviceServer/InputDeviceClient.

This CL adds single process tests that trigger device hotplug events and
ensure that InputDeviceServer forwards input-device information to
InputDeviceClient via Mojo IPC.

InputDeviceClient is refactored to not always register itself as the
InputDeviceManager. This is to allow tests where DeviceDataManager and
one or more InputDeviceClients exist. This functionality is hidden and
requires subclassing InputDeviceClient to access.

BUG=601981
Committed: https://crrev.com/592104aca7f126817491da88187a2572332f0bfd
Cr-Commit-Position: refs/heads/master@{#409787}

[kylechar, 2016-07-29 19:15:17]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[kylechar, 2016-07-29 19:15:17]

+sadrul@ for general review first (since you are familiar with the work it's
testing).

[sadrul, 2016-08-02 15:16:14]

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/B...
File services/ui/input_devices/BUILD.gn (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/B...
services/ui/input_devices/BUILD.gn:39:
"//services/ui/common:run_all_shelltests",
You should use //base/test:run_all_unittests instead.

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/i...
File services/ui/input_devices/input_device_unittests.cc (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/i...
services/ui/input_devices/input_device_unittests.cc:28: class TestClient :
public InputDeviceClient {
TestInputDeviceClient

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/i...
services/ui/input_devices/input_device_unittests.cc:52:
DeviceHotplugEventObserver* GetHotplugObs() {
Observer

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
File services/ui/public/cpp/input_devices/input_device_client.cc (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
services/ui/public/cpp/input_devices/input_device_client.cc:61: : binding_(this)
{
Initialize |is_input_device_manager_| here

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
File services/ui/public/cpp/input_devices/input_device_client.h (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
services/ui/public/cpp/input_devices/input_device_client.h:53:
InputDeviceClient(bool is_input_device_manager);
explicit

[kylechar, 2016-08-02 17:17:55]

Patchset #2 (id:20001) has been deleted

[kylechar, 2016-08-02 17:43:05]

Patchset #2 (id:40001) has been deleted

[kylechar, 2016-08-02 17:46:57]

I also moved the //ui/events/devices dep on //ui/gfx from deps to public_deps to
avoid having to depend on //skia downstream.

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/B...
File services/ui/input_devices/BUILD.gn (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/B...
services/ui/input_devices/BUILD.gn:39:
"//services/ui/common:run_all_shelltests",
On 2016/08/02 15:16:14, sadrul wrote:
> You should use //base/test:run_all_unittests instead.

The Mojo binding stuff doesn't work with //base/test:run_all_unittests. It
produces an error like the following:

input_device_unittests: ../mojo/public/c/system/thunks.cc:47: MojoResult
MojoCreateMessagePipe(const MojoCreateMessagePipeOptions *, MojoHandle *,
MojoHandle *): Assertion `g_thunks.CreateMessagePipe' failed.

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/i...
File services/ui/input_devices/input_device_unittests.cc (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/i...
services/ui/input_devices/input_device_unittests.cc:28: class TestClient :
public InputDeviceClient {
On 2016/08/02 15:16:14, sadrul wrote:
> TestInputDeviceClient

Done.

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/i...
services/ui/input_devices/input_device_unittests.cc:52:
DeviceHotplugEventObserver* GetHotplugObs() {
On 2016/08/02 15:16:14, sadrul wrote:
> Observer

Done.

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
File services/ui/public/cpp/input_devices/input_device_client.cc (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
services/ui/public/cpp/input_devices/input_device_client.cc:61: : binding_(this)
{
On 2016/08/02 15:16:14, sadrul wrote:
> Initialize |is_input_device_manager_| here

Done.

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
File services/ui/public/cpp/input_devices/input_device_client.h (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/public/cpp/inpu...
services/ui/public/cpp/input_devices/input_device_client.h:53:
InputDeviceClient(bool is_input_device_manager);
On 2016/08/02 15:16:14, sadrul wrote:
> explicit

Done.

[sadrul, 2016-08-03 16:02:53]

lgtm

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/B...
File services/ui/input_devices/BUILD.gn (right):

https://codereview.chromium.org/2196563004/diff/1/services/ui/input_devices/B...
services/ui/input_devices/BUILD.gn:39:
"//services/ui/common:run_all_shelltests",
On 2016/08/02 17:46:57, kylechar wrote:
> On 2016/08/02 15:16:14, sadrul wrote:
> > You should use //base/test:run_all_unittests instead.
> 
> The Mojo binding stuff doesn't work with //base/test:run_all_unittests. It
> produces an error like the following:
> 
> input_device_unittests: ../mojo/public/c/system/thunks.cc:47: MojoResult
> MojoCreateMessagePipe(const MojoCreateMessagePipeOptions *, MojoHandle *,
> MojoHandle *): Assertion `g_thunks.CreateMessagePipe' failed.

Because this is not a shell-test, you shouldn't need the shell-test runner here.
Maybe //mojo/edk/test:run_all_unittests will work?

[kylechar, 2016-08-03 18:03:27]

Description was changed from

==========
Add tests for InputDeviceServer/InputDeviceClient.

This CL adds single process tests that trigger device hotplug events and
ensure that InputDeviceServer forwards input-device information to
InputDeviceClient via Mojo IPC.

InputDeviceClient is refactored to not always register itself as the
InputDeviceManager. This is to allow tests where DeviceDataManager and
one or more InputDeviceClients exist. This functionality is hidden and
requires subclass inf InputDeviceClient to access.

BUG=601981
==========

to

==========
Add tests for InputDeviceServer/InputDeviceClient.

This CL adds single process tests that trigger device hotplug events and
ensure that InputDeviceServer forwards input-device information to
InputDeviceClient via Mojo IPC.

InputDeviceClient is refactored to not always register itself as the
InputDeviceManager. This is to allow tests where DeviceDataManager and
one or more InputDeviceClients exist. This functionality is hidden and
requires subclassing InputDeviceClient to access.

BUG=601981
==========

[kylechar, 2016-08-03 18:04:25]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[kylechar, 2016-08-03 18:04:25]

+sky for OWNERS review.

[sky, 2016-08-03 23:40:34]

I'm assuming sadrul reviewed this, so rubber stamp LGTM. Kyle, you should be an
owner of these directories.

[kylechar, 2016-08-04 13:52:10]

On 2016/08/03 23:40:34, sky wrote:
> I'm assuming sadrul reviewed this, so rubber stamp LGTM. Kyle, you should be
an
> owner of these directories.

Thanks sky. Also, sure, I'll send a separate CL to add myself to OWNERS.

[kylechar, 2016-08-04 13:52:38]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-08-04 13:52:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2196563004/#ps80001
(title: "Switch test runner.")

[commit-bot: I haz the power, 2016-08-04 13:53:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 15:10:26]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-04 15:12:58]

Description was changed from

==========
Add tests for InputDeviceServer/InputDeviceClient.

This CL adds single process tests that trigger device hotplug events and
ensure that InputDeviceServer forwards input-device information to
InputDeviceClient via Mojo IPC.

InputDeviceClient is refactored to not always register itself as the
InputDeviceManager. This is to allow tests where DeviceDataManager and
one or more InputDeviceClients exist. This functionality is hidden and
requires subclassing InputDeviceClient to access.

BUG=601981
==========

to

==========
Add tests for InputDeviceServer/InputDeviceClient.

This CL adds single process tests that trigger device hotplug events and
ensure that InputDeviceServer forwards input-device information to
InputDeviceClient via Mojo IPC.

InputDeviceClient is refactored to not always register itself as the
InputDeviceManager. This is to allow tests where DeviceDataManager and
one or more InputDeviceClients exist. This functionality is hidden and
requires subclassing InputDeviceClient to access.

BUG=601981

Committed: https://crrev.com/592104aca7f126817491da88187a2572332f0bfd
Cr-Commit-Position: refs/heads/master@{#409787}
==========

[commit-bot: I haz the power, 2016-08-04 15:12:59]

Patchset 3 (id:??) landed as
https://crrev.com/592104aca7f126817491da88187a2572332f0bfd
Cr-Commit-Position: refs/heads/master@{#409787}