third_party/WebKit/Source/core/editing/EditingUtilities.cpp - Issue 2196553003: Refactoring: Introduce nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2196553003: Refactoring: Introduce nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

index 76a97f1052bb1beaf0c01248f004e17608d72f5c..9b64803fd4ec4799c2a6dd3c2b1708c82ba17b54 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

@@ -972,7 +972,6 @@ String stringWithRebalancedWhitespace(const String& string, bool startIsStartOfP

continue;

}

- // We need to ensure there is no next sibling text node. See http://crbug.com/310149

if (previousCharacterWasSpace || (!i && startIsStartOfParagraph) || (i + 1 == length && shouldEmitNBSPbeforeEnd)) {

rebalancedString.append(noBreakSpaceCharacter);

previousCharacterWasSpace = false;