Refactoring: Introduce nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables

Refactoring: Introduce the local variables
Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none

Committed: https://crrev.com/506f6a158e1136b62e2bf8a85fe72ed0fb476475
Cr-Commit-Position: refs/heads/master@{#408923}

[joone, 2016-07-29 19:36:08]

Description was changed from

==========
Refactoring: Introduce nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd
variables

Use the local variables to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none
==========

to

==========
Refactoring: Introduce the local variables 
Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none
==========

[joone, 2016-07-29 19:38:24]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2016-07-29 19:38:25]

Hi yosin@, please take a look at this CL.

https://codereview.chromium.org/2196553003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2196553003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:738:
bool nextSiblingIsTextNode = textNode->nextSibling() &&
textNode->nextSibling()->isTextNode()
I also added nextSiblingIsTextNode.

[joone, 2016-07-30 06:32:59]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 06:33:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2016-07-30 07:20:20]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 07:20:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 08:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 08:33:12]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-01 01:39:14]

lgtm w/ small nits

Thanks for quick work!

https://codereview.chromium.org/2196553003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2196553003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:738:
bool nextSiblingIsTextNode = textNode->nextSibling() &&
textNode->nextSibling()->isTextNode()
nit: better to have |const|

https://codereview.chromium.org/2196553003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:740:
bool shouldEmitNBSPbeforeEnd =(isEndOfParagraph(visibleDownstreamPos) ||
(unsigned)downstream == text.length()) && !nextSiblingIsTextNode;
nit: better to have |const|

[joone, 2016-08-01 06:17:35]

The CQ bit was checked by joone.hur@intel.com

[joone, 2016-08-01 06:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2196553003/#ps40001
(title: "add const")

[commit-bot: I haz the power, 2016-08-01 06:17:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 07:25:34]

Description was changed from

==========
Refactoring: Introduce the local variables 
Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none
==========

to

==========
Refactoring: Introduce the local variables 
Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none
==========

[commit-bot: I haz the power, 2016-08-01 07:25:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-01 07:27:28]

Description was changed from

==========
Refactoring: Introduce the local variables 
Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none
==========

to

==========
Refactoring: Introduce the local variables
Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13

BUG=none

Committed: https://crrev.com/506f6a158e1136b62e2bf8a85fe72ed0fb476475
Cr-Commit-Position: refs/heads/master@{#408923}
==========

[commit-bot: I haz the power, 2016-08-01 07:27:29]

Patchset 3 (id:??) landed as
https://crrev.com/506f6a158e1136b62e2bf8a85fe72ed0fb476475
Cr-Commit-Position: refs/heads/master@{#408923}