Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2196553002: Tiny: Enable v4_rice* to be built using GYP (Closed)

Created:
4 years, 4 months ago by vakh (use Gerrit instead)
Modified:
4 years, 4 months ago
Reviewers:
palmer, Jialiu Lin
CC:
chromium-reviews, Nathan Parker
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tiny: Enable v4_rice* to be built using GYP BUG=543161, 624567 Committed: https://crrev.com/23c72ff7c5204be4cd59fc6599dad616217c39cf Cr-Commit-Position: refs/heads/master@{#408800}

Patch Set 1 #

Patch Set 2 : Also add v4_rice.h/cc to safe_browsing_db.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
vakh (use Gerrit instead)
Forgot to add the unittest file for GYP earlier since I don't use GYP at ...
4 years, 4 months ago (2016-07-29 01:49:58 UTC) #4
vakh (use Gerrit instead)
Also add v4_rice.h/cc to safe_browsing_db.gypi
4 years, 4 months ago (2016-07-29 01:58:14 UTC) #5
vakh (use Gerrit instead)
4 years, 4 months ago (2016-07-29 21:13:56 UTC) #12
Jialiu Lin
lgtm
4 years, 4 months ago (2016-07-29 23:13:57 UTC) #13
Jialiu Lin
lgtm
4 years, 4 months ago (2016-07-29 23:13:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196553002/20001
4 years, 4 months ago (2016-07-29 23:14:59 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 23:18:52 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 23:20:51 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23c72ff7c5204be4cd59fc6599dad616217c39cf
Cr-Commit-Position: refs/heads/master@{#408800}

Powered by Google App Engine
This is Rietveld 408576698