Push API: send and receive IPC messages for registration.

content/renderer/push_messaging_dispatcher.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/push_messaging_dispatcher.h"
+
+#include "content/common/push_messaging_messages.h"
+#include "content/renderer/render_view_impl.h"
+#include "third_party/WebKit/public/platform/WebPushRegistration.h"
+#include "third_party/WebKit/public/platform/WebString.h"

[Peter Beverloo, 2014/04/01 14:53:18]

WebString.h is already included from the header file.

[Michael van Ouwerkerk, 2014/04/02 14:25:15]

Done.

+
+namespace content {
+
+PushMessagingDispatcher::PushMessagingDispatcher(RenderViewImpl* render_view)
+    : RenderViewObserver(render_view) {}
+
+PushMessagingDispatcher::~PushMessagingDispatcher() {}
+
+bool PushMessagingDispatcher::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(PushMessagingDispatcher, message)
+  IPC_MESSAGE_HANDLER(PushMessagingMsg_RegisterSuccess, OnRegisterSuccess)

[Peter Beverloo, 2014/04/01 14:53:18]

Please indent the IPC_MESSAGE_HANDLER and IPC_MESSAGE_UNHANDLED macros another
block.

[Michael van Ouwerkerk, 2014/04/02 14:25:15]

Done.

+  IPC_MESSAGE_HANDLER(PushMessagingMsg_RegisterError, OnRegisterError)
+  IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void PushMessagingDispatcher::registerPushMessaging(
+    const blink::WebString& sender_id,
+    blink::WebPushRegistrationCallbacks* callbacks) {
+  DCHECK(callbacks);
+  int callbacks_id = registration_callbacks_.Add(callbacks);
+  Send(new PushMessagingHostMsg_Register(
+      routing_id(), callbacks_id, sender_id.utf8()));
+}
+
+void PushMessagingDispatcher::OnRegisterSuccess(
+    int32 callbacks_id,
+    const std::string& endpoint,
+    const std::string& registration_id) {
+  blink::WebPushRegistrationCallbacks* callbacks =
+      registration_callbacks_.Lookup(callbacks_id);
+  DCHECK(callbacks);

[Peter Beverloo, 2014/04/01 14:53:18]

Can we just use CHECK here? If we receive an IPC with an invalid callback Id
then either the IPC is bogus (bad), or there's a bug in the sending side of the
browser process (bad). Both should be severe enough to fix with a high priority,
rather than silently ignoring here.

[Michael van Ouwerkerk, 2014/04/02 14:25:15]

Done.

+  if (!callbacks)
+    return;
+
+  callbacks->onSuccess(new blink::WebPushRegistration(

[Peter Beverloo, 2014/04/01 14:53:18]

We leak the WebPushRegistration object here. Can you put this in a scoped_ptr<>
before invoking |onSuccess|?

[Michael van Ouwerkerk, 2014/04/02 14:25:15]

Done.

+      blink::WebString::fromUTF8(endpoint),
+      blink::WebString::fromUTF8(registration_id)));
+  registration_callbacks_.Remove(callbacks_id);
+}
+
+void PushMessagingDispatcher::OnRegisterError(int32 callbacks_id,
+                                              PushMessagingStatus status) {
+  blink::WebPushRegistrationCallbacks* callbacks =
+      registration_callbacks_.Lookup(callbacks_id);
+  DCHECK(callbacks);
+  if (!callbacks)
+    return;
+
+  scoped_ptr<blink::WebPushError> error(
+      new blink::WebPushError(
+          blink::WebPushError::AbortError,
+          blink::WebString::fromUTF8(PushMessagingStatusToString(status))));
+  callbacks->onError(error.release());
+  registration_callbacks_.Remove(callbacks_id);
+}
+
+}  // namespace content