Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2196503003: Revert of services/ui: Revert CLs that broke Windows. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, tfarina, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of services/ui: Revert CLs that broke Windows. (patchset #2 id:20001 of https://codereview.chromium.org/2194893002/ ) Reason for revert: crrev.com/408695 fixes the issue. So we can reland these CLs. Original issue's description: > services/ui: Revert CLs that broke Windows. > > The new GPU code path does not seem to work correctly on Windows yet > (everything is black). So restore the deprecated path. > > Revert "services/ui: Remove deprecated gpu code" crrev.com/408207 > Revert "services/ui: Remove unused connector argument" crrev.com/408230 > > BUG=623157, 630893 > TBR=ben@, piman@, penghuang@ > > Committed: https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d > Cr-Commit-Position: refs/heads/master@{#408648} TBR=ben@chromium.org,piman@chromium.org,penghuang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623157, 630893 Committed: https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534 Cr-Commit-Position: refs/heads/master@{#408710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -3473 lines) Patch
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/mus/non_client_frame_controller.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mus.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 2 chunks +1 line, -4 lines 0 comments Download
M mash/login/login.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/common/gpu_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/common/gpu_service.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M services/ui/common/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/common/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/ui/gles2/BUILD.gn View 1 chunk +0 lines, -89 lines 0 comments Download
D services/ui/gles2/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D services/ui/gles2/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/ui/gles2/command_buffer_driver.h View 1 chunk +0 lines, -173 lines 0 comments Download
D services/ui/gles2/command_buffer_driver.cc View 1 chunk +0 lines, -568 lines 0 comments Download
D services/ui/gles2/command_buffer_driver_manager.h View 1 chunk +0 lines, -46 lines 0 comments Download
D services/ui/gles2/command_buffer_driver_manager.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D services/ui/gles2/command_buffer_impl.h View 1 chunk +0 lines, -126 lines 0 comments Download
D services/ui/gles2/command_buffer_impl.cc View 1 chunk +0 lines, -301 lines 0 comments Download
D services/ui/gles2/command_buffer_local.h View 1 chunk +0 lines, -184 lines 0 comments Download
D services/ui/gles2/command_buffer_local.cc View 1 chunk +0 lines, -568 lines 0 comments Download
D services/ui/gles2/command_buffer_local_client.h View 1 chunk +0 lines, -31 lines 0 comments Download
D services/ui/gles2/command_buffer_task_runner.h View 1 chunk +0 lines, -78 lines 0 comments Download
D services/ui/gles2/command_buffer_task_runner.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D services/ui/gles2/gl_surface_adapter.h View 1 chunk +0 lines, -71 lines 0 comments Download
D services/ui/gles2/gl_surface_adapter.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D services/ui/gles2/gpu_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/ui/gles2/gpu_impl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D services/ui/gles2/gpu_memory_tracker.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/ui/gles2/gpu_memory_tracker.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D services/ui/gles2/gpu_state.h View 1 chunk +0 lines, -107 lines 0 comments Download
D services/ui/gles2/gpu_state.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D services/ui/gles2/ozone_gpu_memory_buffer.h View 1 chunk +0 lines, -71 lines 0 comments Download
D services/ui/gles2/ozone_gpu_memory_buffer.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D services/ui/gles2/raster_thread_helper.h View 1 chunk +0 lines, -34 lines 0 comments Download
D services/ui/gles2/raster_thread_helper.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M services/ui/public/cpp/bitmap_uploader.h View 2 chunks +1 line, -5 lines 0 comments Download
M services/ui/public/cpp/context_provider.h View 2 chunks +1 line, -2 lines 0 comments Download
M services/ui/public/cpp/gles2_context.h View 2 chunks +2 lines, -8 lines 0 comments Download
M services/ui/public/cpp/lib/bitmap_uploader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/ui/public/cpp/lib/context_provider.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M services/ui/public/cpp/lib/gles2_context.cc View 3 chunks +27 lines, -47 lines 0 comments Download
A services/ui/public/cpp/lib/raster_thread_helper.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A services/ui/public/cpp/raster_thread_helper.h View 1 chunk +34 lines, -0 lines 0 comments Download
M services/ui/service.h View 3 chunks +0 lines, -6 lines 0 comments Download
M services/ui/service.cc View 9 chunks +2 lines, -44 lines 0 comments Download
M services/ui/surfaces/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M services/ui/surfaces/display_compositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 2 chunks +1 line, -2 lines 0 comments Download
D services/ui/surfaces/ozone_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M services/ui/surfaces/surfaces_context_provider.h View 5 chunks +1 line, -14 lines 0 comments Download
M services/ui/surfaces/surfaces_context_provider.cc View 3 chunks +30 lines, -78 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/frame_generator.h View 3 chunks +0 lines, -3 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/ws/platform_display.cc View 2 chunks +1 line, -4 lines 0 comments Download
M services/ui/ws/platform_display_init_params.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/platform_display_init_params.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_tree_host_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 4 chunks +0 lines, -11 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 4 chunks +1 line, -21 lines 0 comments Download
M ui/views/mus/surface_binding.h View 2 chunks +1 line, -7 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 5 chunks +8 lines, -17 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 3 chunks +3 lines, -8 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
Created Revert of services/ui: Revert CLs that broke Windows.
4 years, 4 months ago (2016-07-29 19:13:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196503003/1
4 years, 4 months ago (2016-07-29 19:14:21 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 4 months ago (2016-07-29 19:14:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:16:31 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:18:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534
Cr-Commit-Position: refs/heads/master@{#408710}

Powered by Google App Engine
This is Rietveld 408576698