Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2196493003: Pass in the right sender to font proxy init (Closed)

Created:
4 years, 4 months ago by Ilya Kulshin
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass in the right sender to font proxy init Previous change passed the sender to FontFallback init, but not DWriteFontCollectionProxy which is what really matters. This will ensure that both classes get the right sender. BUG=631254 Committed: https://crrev.com/1e94095743b78b9096b998391a2a4d975577471d Cr-Commit-Position: refs/heads/master@{#408804}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Ilya Kulshin
ptal This is a followup to https://chromium.googlesource.com/chromium/src/+/ddaf9994ab75ff143da0c2f5c44499e49db1815f, which somehow failed to update a critical piece ...
4 years, 4 months ago (2016-07-29 22:22:32 UTC) #6
Ilya Kulshin
+scottmg/jschuh as owners
4 years, 4 months ago (2016-07-29 22:36:47 UTC) #8
scottmg
Not sure about previous CL, but this lgtm.
4 years, 4 months ago (2016-07-29 22:50:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196493003/20001
4 years, 4 months ago (2016-07-29 23:26:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 23:29:39 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 23:30:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e94095743b78b9096b998391a2a4d975577471d
Cr-Commit-Position: refs/heads/master@{#408804}

Powered by Google App Engine
This is Rietveld 408576698