[Chromoting] Unit Tests for GlRenderer

remoting/client/gl_renderer_core.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_CLIENT_GL_RENDERER_CORE_H_
+#define REMOTING_CLIENT_GL_RENDERER_CORE_H_
+
+#include <array>
+#include <memory>
+
+namespace webrtc {
+class DesktopFrame;
+}  // namespace webrtc
+
+namespace remoting {
+
+namespace protocol {
+class CursorShapeInfo;
+}  // namespace protocol
+
+// Interface for logics that render host desktop through OpenGL.
+class GlRendererCore {

[Sergey Ulanov, 2016/08/01 21:33:05]

With this change GlRenderer becomes just a think wrapper for GlRendererCore and
then you supply fake GlRendererCore implementation for the test. This means that
the tests only run the code in GlRenderer and so they are not very useful. I
think it would be better to run the actual renderer and execute code from the
other Gl* classes. Then the test could render everything to a framebuffer, read
it back and verify that everything is rendered properly.

[Yuwei, 2016/08/01 22:04:39]

My initial thought was to test the delegate calls and render scheduling. Testing
the actual rendering output sounds like an integration test and would be more
complex.

I can still manage to use Mesa OpenGL or something to get the code compile in
different platforms. I can spend some time making tests for the render result if
you think that's useful.

+ public:
+  static std::unique_ptr<GlRendererCore> CreateCore();

[Sergey Ulanov, 2016/08/01 21:33:05]

We use static interface constructors like this for platform-specific code, but
not to mock interfaces for testing. If you need to mock a layer under the class
being tested then the class should be getting a pointer to the lower layer
implementation somehow explicitly, instead of calling a static constructor.
But see my previous comment, I don't think we actually need to mock anything
under GlRenderer.

[Yuwei, 2016/08/02 00:13:10]

Obsolete.

+  virtual ~GlRendererCore() {}
+  virtual void CreateCanvas(int gl_version) = 0;
+  virtual void DestroyCanvas() = 0;
+
+  // Returns true if there is an ongoing animation handled by the OpenGL
+  // renderer.
+  virtual bool DrawFrame() = 0;
+
+  virtual void SetPixelTransformation(const std::array<float, 9>& matrix) = 0;
+  virtual void MoveCursor(int x, int y) = 0;
+  virtual void StartFeedbackAnimation(int x, int y, float diameter) = 0;
+  virtual void SetCursorVisibility(bool visible) = 0;
+  virtual void SetDesktopFrame(const webrtc::DesktopFrame& frame) = 0;
+  virtual void SetCursorShape(const protocol::CursorShapeInfo& shape) = 0;
+  virtual void SetViewSize(int width, int height) = 0;
+  virtual void SetCanvasSize(int width, int height) = 0;
+  virtual int GetCanvasWidth() const = 0;
+  virtual int GetCanvasHeight() const = 0;
+
+ protected:
+  GlRendererCore() {}
+};
+
+}  // namespace remoting
+#endif  // REMOTING_CLIENT_GL_RENDERER_CORE_H_