Revert "Revert "fix #26141, add support for type arguments to constants""

Revert "Revert "fix #26141, add support for type arguments to constants""

This reverts commit bd6669ee114bd9cc2eb0d8efd00e15eb329455b4.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/0939f5b47048779e0162a011629515b926319a0b

[Jennifer Messerly, 2016-07-29 00:28:37]

jmesserly@google.com changed reviewers:
+ paulberry@google.com

[Jennifer Messerly, 2016-07-29 00:28:38]

Hi Paul,

Here's the fixed version. The original CL is the first patch set, with the
second one having the fix for the build bots:

https://codereview.chromium.org/2196483002/diff2/1:20001/pkg/analyzer/lib/src...

Basically, I needed to make sure type parameters weren't sneaking by in
non-strong mode.

[Paul Berry, 2016-07-29 12:22:47]

lgtm

https://codereview.chromium.org/2196483002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/constant/evaluation.dart (right):

https://codereview.chromium.org/2196483002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/constant/evaluation.dart:1535: return null;
Nit: it would be nice to have a comment explaining why this is necessary, e.g.:

// Constants may only refer to type parameters in strong mode.

[Jennifer Messerly, 2016-07-29 16:04:50]

Thanks again!

https://codereview.chromium.org/2196483002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/constant/evaluation.dart (right):

https://codereview.chromium.org/2196483002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/constant/evaluation.dart:1535: return null;
On 2016/07/29 12:22:46, Paul Berry wrote:
> Nit: it would be nice to have a comment explaining why this is necessary,
e.g.:
> 
> // Constants may only refer to type parameters in strong mode.

Done.

[Jennifer Messerly, 2016-07-29 16:05:07]

Description was changed from

==========
Revert "Revert "fix #26141, add support for type arguments to constants""

This reverts commit bd6669ee114bd9cc2eb0d8efd00e15eb329455b4.
==========

to

==========
Revert "Revert "fix #26141, add support for type arguments to constants""

This reverts commit bd6669ee114bd9cc2eb0d8efd00e15eb329455b4.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0939f5b47048779e0162a011629515b926319a0b
==========

[Jennifer Messerly, 2016-07-29 16:05:09]

Committed patchset #3 (id:40001) manually as
0939f5b47048779e0162a011629515b926319a0b (presubmit successful).