Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2196463002: Reland of mote-debugging-port for guest sessions. (Closed)

Created:
4 years, 4 months ago by achuithb
Modified:
4 years, 4 months ago
Reviewers:
emaxx
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of mote-debugging-port for guest sessions. (patchset #1 id:1 of https://codereview.chromium.org/2189503002/ ) Reason for revert: Problem is still happening, so this isn't responsible. Original issue's description: > Revert of remote-debugging-port for guest sessions. (patchset #1 id:1 of https://codereview.chromium.org/2141303003/ ) > > Reason for revert: > Speculative revert for crbug.com/631640 > > BUG=631640 > > Original issue's description: > > remote-debugging-port for guest sessions. > > > > --remote-debugging-port flag is lost when guest sessions are started on > > chromeos. > > > > BUG=None > > > > Committed: https://crrev.com/7268c3d1f3f991740f536d9680426251392b98e8 > > Cr-Commit-Position: refs/heads/master@{#405633} > > TBR=emaxx@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=None > > Committed: https://crrev.com/f85dca4cad17e2a4464d9e6f722f44e1c8082a93 > Cr-Commit-Position: refs/heads/master@{#408009} TBR=emaxx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=631640 Committed: https://crrev.com/8fd08476c1fa4a64902c535310c8f642910e3624 Cr-Commit-Position: refs/heads/master@{#408510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
achuithb
Created Reland of mote-debugging-port for guest sessions.
4 years, 4 months ago (2016-07-28 23:12:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196463002/1
4 years, 4 months ago (2016-07-28 23:12:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 23:53:25 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 23:55:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fd08476c1fa4a64902c535310c8f642910e3624
Cr-Commit-Position: refs/heads/master@{#408510}

Powered by Google App Engine
This is Rietveld 408576698