Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2196453004: Revert of [Media Router Contextual Menu] Test 'checked' state of cloud services item. (Closed)

Created:
4 years, 4 months ago by apacible
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router Contextual Menu] Test 'checked' state of cloud services item. (patchset #2 id:60001 of https://codereview.chromium.org/2190223002/ ) Reason for revert: Broke official build. Original issue's description: > [Media Router Contextual Menu] Test 'checked' state of cloud services item. > > Add a test to check whether the "Enable cloud services" item is currently checked or not. > > BUG=623330 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/5dc8d635fceca17f8bf56044865ae4afb462f48c > Cr-Commit-Position: refs/heads/master@{#408640} TBR=msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623330 Committed: https://crrev.com/003691355b04b283dd67dd12ea838816d1bc1184 Cr-Commit-Position: refs/heads/master@{#408681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
apacible
Created Revert of [Media Router Contextual Menu] Test 'checked' state of cloud services item.
4 years, 4 months ago (2016-07-29 17:49:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196453004/1
4 years, 4 months ago (2016-07-29 17:49:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 17:50:07 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:51:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/003691355b04b283dd67dd12ea838816d1bc1184
Cr-Commit-Position: refs/heads/master@{#408681}

Powered by Google App Engine
This is Rietveld 408576698