Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2196453003: Do not use deprecated MessageLoop methods in //media/filters:media_vpx_video_decoder_fuzzer. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
Reviewers:
jrummell
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use deprecated MessageLoop methods in //media/filters:media_vpx_video_decoder_fuzzer. R=jrummell@chromium.org Committed: https://crrev.com/e001515d970b5b137f8aae5188c35cb4414f2a8a Cr-Commit-Position: refs/heads/master@{#408801}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M media/filters/vpx_video_decoder_fuzzertest.cc View 2 chunks +4 lines, -3 lines 2 comments Download

Messages

Total messages: 12 (6 generated)
Robert Sesek
4 years, 4 months ago (2016-07-29 16:34:49 UTC) #1
jrummell
LGTM. https://codereview.chromium.org/2196453003/diff/1/media/filters/vpx_video_decoder_fuzzertest.cc File media/filters/vpx_video_decoder_fuzzertest.cc (right): https://codereview.chromium.org/2196453003/diff/1/media/filters/vpx_video_decoder_fuzzertest.cc#newcode26 media/filters/vpx_video_decoder_fuzzertest.cc:26: base::MessageLoop message_loop; This isn't used anywhere, so is ...
4 years, 4 months ago (2016-07-29 23:10:52 UTC) #6
Robert Sesek
https://codereview.chromium.org/2196453003/diff/1/media/filters/vpx_video_decoder_fuzzertest.cc File media/filters/vpx_video_decoder_fuzzertest.cc (right): https://codereview.chromium.org/2196453003/diff/1/media/filters/vpx_video_decoder_fuzzertest.cc#newcode26 media/filters/vpx_video_decoder_fuzzertest.cc:26: base::MessageLoop message_loop; On 2016/07/29 23:10:52, jrummell wrote: > This ...
4 years, 4 months ago (2016-07-29 23:16:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196453003/1
4 years, 4 months ago (2016-07-29 23:16:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 23:20:32 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 23:22:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e001515d970b5b137f8aae5188c35cb4414f2a8a
Cr-Commit-Position: refs/heads/master@{#408801}

Powered by Google App Engine
This is Rietveld 408576698