Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2196413003: GN: add some missing SkCodec defines (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add some missing SkCodec defines TURBO_HAS_... WEBP_SWAP_16BIT_CSP BUG=skia:5591 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196413003 Committed: https://skia.googlesource.com/skia/+/7c1ae7af4ff3912bdb518ac21571225155ece365

Patch Set 1 #

Patch Set 2 : in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libwebp/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mtklein_C
4 years, 4 months ago (2016-08-01 22:20:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196413003/1
4 years, 4 months ago (2016-08-01 22:20:58 UTC) #5
msarett
lgtm
4 years, 4 months ago (2016-08-01 22:22:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196413003/20001
4 years, 4 months ago (2016-08-01 22:25:58 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:50:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7c1ae7af4ff3912bdb518ac21571225155ece365

Powered by Google App Engine
This is Rietveld 408576698