Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Issue 2196393007: Merge GrClipMaskManager into GrClipStackClip (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1079 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrClip.h View 2 chunks +0 lines, -34 lines 0 comments Download
M include/gpu/GrContext.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrClip.cpp View 2 chunks +0 lines, -34 lines 0 comments Download
D src/gpu/GrClipMaskManager.h View 1 chunk +0 lines, -94 lines 0 comments Download
D src/gpu/GrClipMaskManager.cpp View 1 chunk +0 lines, -810 lines 0 comments Download
A + src/gpu/GrClipStackClip.h View 2 chunks +31 lines, -34 lines 0 comments Download
A + src/gpu/GrClipStackClip.cpp View 14 chunks +75 lines, -62 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrStencilAttachment.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/ClipBoundsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
csmartdalton
4 years, 4 months ago (2016-08-03 16:37:58 UTC) #3
robertphillips
lgtm
4 years, 4 months ago (2016-08-04 21:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196393007/20001
4 years, 4 months ago (2016-08-04 22:22:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12200)
4 years, 4 months ago (2016-08-04 22:24:36 UTC) #13
csmartdalton
4 years, 4 months ago (2016-08-04 22:28:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196393007/20001
4 years, 4 months ago (2016-08-06 05:15:08 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 05:32:20 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c6f411e72b1fea6608f540f64a57bcacbe3378cd

Powered by Google App Engine
This is Rietveld 408576698