Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2196363003: Make analyzer strong-mode clean (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -55 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/.analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 5 chunks +46 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 14 chunks +19 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/inputs.dart View 7 chunks +15 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/sdk_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 7 chunks +8 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
There is also a little bit of additional clean-up, which I can put in a ...
4 years, 4 months ago (2016-08-01 18:45:52 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-01 18:53:41 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-01 18:55:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
16cc45417cb75e0cae4fa7678adffb57ac3dec7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698