third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-in-fixed-overflow.html - Issue 2196363002: Modify LayoutTests to prep for compositing solid background scollers

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-in-fixed-overflow.html

Issue 2196363002: Modify LayoutTests to prep for compositing solid background scollers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/change-preferCompositingToLCDText-setting.html ('k') | third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-nonscrollable-body-mismatch-containers.html » ('j') | third_party/WebKit/Source/web/tests/data/composited_selection_bounds_editable.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 .fixed {	3 .fixed {

4 position: fixed;	4 position: fixed;

5 }	5 }

6 .overflow {	6 .overflow {

7 width: 100%;	7 width: 100%;

8 height: 100%;	8 height: 100%;

9 overflow-y: scroll;	9 overflow-y: scroll;

10 }	10 }

11 .yellow {	11 .yellow {

12 left: 200px;	12 left: 200px;

13 width: 100px;	13 width: 100px;

14 height: 100px;	14 height: 100px;

15 background-color: yellow;	15 background-color: yellow;

16 }	16 }

17	17

18 .blue {	18 .blue {

19 width: 100px;	19 width: 100px;

20 height: 1000px;	20 height: 1000px;

21 background-color: blue;	21 background-color: blue;
	flackr 2016/08/03 20:00:01 Should background color still be here? The image w Should background color still be here? The image will completely cover it up right? Stephen Chennney 2016/08/03 20:21:15 Yes, it will cover it up, but we only use backgrou Show quoted text On 2016/08/03 20:00:01, flackr wrote: > Should background color still be here? The image will completely cover it up > right? Yes, it will cover it up, but we only use background color in determining composited scrolling, so I want to leave it in. A gradient with opaque colors completely fills a space if there is no background-image-size given or other things to reduce coverage, but we don't check for that right now. flackr 2016/08/03 20:34:14 Perhaps I am missing something. .blue is not a scr Show quoted text On 2016/08/03 at 20:21:15, Stephen Chennney wrote: > On 2016/08/03 20:00:01, flackr wrote: > > Should background color still be here? The image will completely cover it up > > right? > > Yes, it will cover it up, but we only use background color in determining composited scrolling, so I want to leave it in. > > A gradient with opaque colors completely fills a space if there is no background-image-size given or other things to reduce coverage, but we don't check for that right now. Perhaps I am missing something. .blue is not a scroller, and we won't yet check whether the entire scrolling contents has opaque backgrounds afaik. Also, why do we want this to become a composited scroller if it's not today - i.e. keeping it not composited would preserve the current test result. I thought the gradient was just to be able to visually tell where you were in the scroll. Stephen Chennney 2016/08/03 20:44:26 .blue is a scroller if the window size is less tha Show quoted text On 2016/08/03 20:34:14, flackr wrote: > On 2016/08/03 at 20:21:15, Stephen Chennney wrote: > > On 2016/08/03 20:00:01, flackr wrote: > > > Should background color still be here? The image will completely cover it up > > > right? > > > > Yes, it will cover it up, but we only use background color in determining > composited scrolling, so I want to leave it in. > > > > A gradient with opaque colors completely fills a space if there is no > background-image-size given or other things to reduce coverage, but we don't > check for that right now. > > Perhaps I am missing something. .blue is not a scroller, and we won't yet check > whether the entire scrolling contents has opaque backgrounds afaik. Also, why do > we want this to become a composited scroller if it's not today - i.e. keeping it > not composited would preserve the current test result. I thought the gradient > was just to be able to visually tell where you were in the scroll. .blue is a scroller if the window size is less than 1000px, as it is in layout tests. My interest was in manual testing the correctness of things when it is composited, but in hindsight that's inconsistent unless I also change the .overflow height to be something explicitly less than 1000px. And I want it to be composited so that we're testing the user's experience (or will be). I would go with fixing the size so that the test works manually in any window size, but I'd also be satisfied just entirely reverting this change. Do you have any preference?
	22 background-image: linear-gradient(to bottom,red,orange,yellow, green, blue,ind igo,violet);

22 }	23 }

23 </style>	24 </style>

24 <div class="overflow fixed">	25 <div class="overflow fixed">

25 <div class="yellow fixed"></div>	26 <div class="yellow fixed"></div>

26 <div class="blue"></div>	27 <div class="blue"></div>

27 </div>	28 </div>

28 <pre></pre>	29 <pre></pre>

29 <script src="../../resources/run-after-layout-and-paint.js"></script>	30 <script src="../../resources/run-after-layout-and-paint.js"></script>

30 <script>	31 <script>

31 if (window.testRunner && window.internals) {	32 if (window.testRunner && window.internals) {

32 testRunner.dumpAsText();	33 testRunner.dumpAsText();

33 testRunner.waitUntilDone();	34 testRunner.waitUntilDone();

34 internals.settings.setPreferCompositingToLCDTextEnabled(true);	35 internals.settings.setPreferCompositingToLCDTextEnabled(true);

35 }	36 }

36	37

37 runAfterLayoutAndPaint(function() {	38 runAfterLayoutAndPaint(function() {

38 if (window.testRunner)	39 if (window.testRunner)

39 document.querySelector('pre').textContent = window.internals.layerTreeAsText (document);	40 document.querySelector('pre').textContent = window.internals.layerTreeAsText (document);

40 }, true);	41 }, true);

41 </script>	42 </script>

OLD	NEW