Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2196343002: [Android] Fix backwards compatibility flags with perf tests running in platform mode. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix backwards compatibility flags with perf tests running in platform mode. BUG=615157, 632922 Committed: https://crrev.com/a00fe127bfd2be32a412e4c0c73b4ced7b8bf6ab Cr-Commit-Position: refs/heads/master@{#409016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/pylib/perf/perf_test_instance.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
rnephew (Reviews Here)
4 years, 4 months ago (2016-08-01 16:56:20 UTC) #2
rnephew (Reviews Here)
4 years, 4 months ago (2016-08-01 16:56:22 UTC) #3
jbudorick
lgtm
4 years, 4 months ago (2016-08-01 17:01:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196343002/1
4 years, 4 months ago (2016-08-01 17:05:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/113821)
4 years, 4 months ago (2016-08-01 18:26:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196343002/1
4 years, 4 months ago (2016-08-01 18:32:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 19:16:45 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 19:18:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a00fe127bfd2be32a412e4c0c73b4ced7b8bf6ab
Cr-Commit-Position: refs/heads/master@{#409016}

Powered by Google App Engine
This is Rietveld 408576698