content/renderer/render_frame_impl.cc - Issue 2196333002: PlzNavigate: Clear provisional history item on redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2196333002: PlzNavigate: Clear provisional history item on redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timing_api

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 67c518fb64f8fc52eb3b24f25ece293e60fcd993..6372686d5a0dcb68032f7d942c41a3b88f8f4665 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -3195,9 +3195,8 @@ void RenderFrameImpl::didCreateDataSource(blink::WebLocalFrame* frame,

navigation_state->request_params().redirects;

redirectChain.push_back(navigation_state->common_params().url);

- datasource->updateNavigationTimings(redirect_start, redirect_end,

- fetch_start, redirectChain);

+ datasource->updateNavigation(redirect_start, redirect_end, fetch_start,

+ redirectChain);

// TODO(clamy) We need to provide additional timing values for the

// Navigation Timing API to work with browser-side navigations.

// UnloadEventStart and UnloadEventEnd are still missing.