third_party/WebKit/Source/core/loader/DocumentLoader.h - Issue 2196333002: PlzNavigate: Clear provisional history item on redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoader.h

Issue 2196333002: PlzNavigate: Clear provisional history item on redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timing_api

Patch Set: Change tests filter Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter ('k') | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentLoader.h

diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.h b/third_party/WebKit/Source/core/loader/DocumentLoader.h

index a97fb85d4b83f293c3000a070432e97892721f8f..db373cd178a8df0f81d1407bcc758b9f7707a7f2 100644

--- a/third_party/WebKit/Source/core/loader/DocumentLoader.h

+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.h

@@ -153,6 +153,10 @@ public:

Resource* startPreload(Resource::Type, FetchRequest&);

+ // Declare a redirection that happened outside of the document loader,

+ // before its instantiation.

+ void didRedirect(const KURL& oldURL, const KURL& newURL);

Nate Chapin 2016/08/18 16:49:57 Sorry, missed this earlier, should this be protect

arthursonzogni 2016/08/19 08:20:30 Yes, you are right. I also removed the comment say

DECLARE_VIRTUAL_TRACE();

protected: