PlzNavigate: Clear provisional history item on redirects.

third_party/WebKit/Source/core/loader/DocumentLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 191 matching lines @@
         break;
     default:
         ASSERT_NOT_REACHED();
     }
 
     if (resource)
         fetcher()->preloadStarted(resource);
     return resource;
 }
 
+void DocumentLoader::addExternalRedirect(const KURL& oldURL, const KURL& newURL)
+{
+    timing().addRedirect(oldURL, newURL);
+
+    // If a redirection happens during a back/forward navigation, don't restore
+    // any state from the old HistoryItem.

[Charlie Reis, 2016/08/11 21:05:01]

It's probably worth mentioning that we only have a provisional history item for
back/forward navigations, since this wasn't obvious at first glance.

[arthursonzogni, 2016/08/16 09:26:20]

Done.

+    FrameLoader* frameloader = frameLoader();

[Charlie Reis, 2016/08/11 21:05:01]

nit: No need to declare this.  (If we did have it, the spelling would be
frameLoader.)

[arthursonzogni, 2016/08/16 09:26:20]

Done.

+    if (frameloader)

[Charlie Reis, 2016/08/11 21:05:01]

Is it possible for frameLoader() to return null here?  Most of the other uses
don't have a check for it.

[arthursonzogni, 2016/08/16 09:26:20]

I am sure that where the function is called (in
RenderFrameImpl::didCreateDataSource), the frameloader is not null. I think I
should replace the condition with a DCHECK(...)

+        frameloader->discardProvisionalHistoryItem();
+}
+
 void DocumentLoader::dispatchLinkHeaderPreloads(ViewportDescriptionWrapper* viewport, LinkLoader::MediaPreloadPolicy mediaPolicy)
 {
     LinkLoader::loadLinksFromHeader(response().httpHeaderField(HTTPNames::Link), response().url(), m_frame->document(), NetworkHintsInterfaceImpl(), LinkLoader::OnlyLoadResources, mediaPolicy, viewport);
 }
 
 void DocumentLoader::didChangePerformanceTiming()
 {
     if (frame() && frame()->isMainFrame() && m_state >= Committed) {
         frameLoader()->client()->didChangePerformanceTiming();
     }
@@ skipping 496 matching lines @@
 {
     m_writer = createWriterFor(init, mimeType(), m_writer ? m_writer->encoding() : emptyAtom, true, ForceSynchronousParsing);
     if (!source.isNull())
         m_writer->appendReplacingData(source);
     endWriting(m_writer.get());
 }
 
 DEFINE_WEAK_IDENTIFIER_MAP(DocumentLoader);
 
 } // namespace blink