Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2196333002: PlzNavigate: Clear provisional history item on redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timing_api
Patch Set: Rebasing again, Trybot issues. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 3142 matching lines...) Expand 10 before | Expand all | Expand 10 after
3153 double redirect_start = ConvertToBlinkTime( 3153 double redirect_start = ConvertToBlinkTime(
3154 navigation_state->request_params().navigation_timing.redirect_start); 3154 navigation_state->request_params().navigation_timing.redirect_start);
3155 double redirect_end = ConvertToBlinkTime( 3155 double redirect_end = ConvertToBlinkTime(
3156 navigation_state->request_params().navigation_timing.redirect_end); 3156 navigation_state->request_params().navigation_timing.redirect_end);
3157 double fetch_start = ConvertToBlinkTime( 3157 double fetch_start = ConvertToBlinkTime(
3158 navigation_state->request_params().navigation_timing.fetch_start); 3158 navigation_state->request_params().navigation_timing.fetch_start);
3159 std::vector<GURL> redirectChain = 3159 std::vector<GURL> redirectChain =
3160 navigation_state->request_params().redirects; 3160 navigation_state->request_params().redirects;
3161 redirectChain.push_back(navigation_state->common_params().url); 3161 redirectChain.push_back(navigation_state->common_params().url);
3162 3162
3163 datasource->updateNavigationTimings(redirect_start, redirect_end, 3163 datasource->updateNavigation(redirect_start, redirect_end, fetch_start,
3164 fetch_start, redirectChain); 3164 redirectChain);
3165
3166 // TODO(clamy) We need to provide additional timing values for the 3165 // TODO(clamy) We need to provide additional timing values for the
3167 // Navigation Timing API to work with browser-side navigations. 3166 // Navigation Timing API to work with browser-side navigations.
3168 // UnloadEventStart and UnloadEventEnd are still missing. 3167 // UnloadEventStart and UnloadEventEnd are still missing.
3169 } 3168 }
3170 3169
3171 // Create the serviceworker's per-document network observing object if it 3170 // Create the serviceworker's per-document network observing object if it
3172 // does not exist (When navigation happens within a page, the provider already 3171 // does not exist (When navigation happens within a page, the provider already
3173 // exists). 3172 // exists).
3174 if (ServiceWorkerNetworkProvider::FromDocumentState( 3173 if (ServiceWorkerNetworkProvider::FromDocumentState(
3175 DocumentState::FromDataSource(datasource))) 3174 DocumentState::FromDataSource(datasource)))
(...skipping 3178 matching lines...) Expand 10 before | Expand all | Expand 10 after
6354 // event target. Potentially a Pepper plugin will receive the event. 6353 // event target. Potentially a Pepper plugin will receive the event.
6355 // In order to tell whether a plugin gets the last mouse event and which it 6354 // In order to tell whether a plugin gets the last mouse event and which it
6356 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6355 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6357 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6356 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6358 // |pepper_last_mouse_event_target_|. 6357 // |pepper_last_mouse_event_target_|.
6359 pepper_last_mouse_event_target_ = nullptr; 6358 pepper_last_mouse_event_target_ = nullptr;
6360 #endif 6359 #endif
6361 } 6360 }
6362 6361
6363 } // namespace content 6362 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698