Source/core/rendering/RenderObject.h - Issue 219633002: Proper support for multiple text decorations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.h

Issue 219633002: Proper support for multiple text decorations. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/InlineTextBox.cpp ('K') | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | Source/core/rendering/RenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderObject.h

diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h

index a4d483d79055044d9442017b0163d0681bb7a0f1..fb785d480606536b6fa7eddc630da09d5ce41309 100644

--- a/Source/core/rendering/RenderObject.h

+++ b/Source/core/rendering/RenderObject.h

@@ -789,13 +789,7 @@ public:

virtual CursorDirective getCursor(const LayoutPoint&, Cursor&) const;

- struct AppliedTextDecoration {

- Color color;

- TextDecorationStyle style;

- AppliedTextDecoration() : color(Color::transparent), style(TextDecorationStyleSolid) { }

- };

- void getTextDecorations(unsigned decorations, AppliedTextDecoration& underline, AppliedTextDecoration& overline, AppliedTextDecoration& linethrough, bool quirksMode = false, bool firstlineStyle = false);

+ Color getUnderlineColor(bool quirksMode, bool firstlineStyle);

esprehn 2014/03/31 17:41:24 We should use enums, this is confusing. Also alway

// Return the RenderLayerModelObject in the container chain which is responsible for painting this object, or 0

// if painting is root-relative. This is the container that should be passed to the 'forRepaint'

« Source/core/rendering/InlineTextBox.cpp ('K') | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | Source/core/rendering/RenderObject.cpp » ('J')