chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java - Issue 2196273002: Zine: support multiple sections in the ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java

Issue 2196273002: Zine: support multiple sections in the ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingListItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java

index 6e0511934cbad8bd8d76cdfbb502325c4cf5ecde..dac9ab5d9c1256974c77cc81558298dcab0b9dee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java

@@ -14,6 +14,7 @@ import org.chromium.base.Log;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ntp.UiConfig;

import org.chromium.chrome.browser.ntp.snippets.CategoryStatus;

+import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;

import org.chromium.chrome.browser.signin.AccountSigninActivity;

import org.chromium.chrome.browser.signin.SigninAccessPoint;

@@ -135,7 +136,8 @@ public abstract class StatusListItem implements NewTabPageListItem {

private final int mDescriptionStringId;

private final int mActionStringId;

- public static StatusListItem create(int categoryStatus, NewTabPageAdapter adapter) {

+ public static StatusListItem create(@CategoryStatusEnum int categoryStatus,

+ NewTabPageAdapter adapter) {

switch (categoryStatus) {

// TODO(dgn): AVAILABLE_LOADING and INITIALIZING should show a progress indicator.

case CategoryStatus.AVAILABLE: