Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2196263002: CHECK invalid arguments to CallSite constructor (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Michael Starzinger, rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CHECK invalid arguments to CallSite constructor This is a temporary measure to ensure clusterfuzz crashes at two dedicated sites until the CallSite constructor is made inaccessible from JS. R=yangguo@chromium.org BUG= Committed: https://crrev.com/df4196db97f3ea6add3eee7fe4e359125d9cca82 Cr-Commit-Position: refs/heads/master@{#38216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/messages.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jgruber
This converts a couple of DCHECKs into CHECKs in order to make clusterfuzz crash reliably ...
4 years, 4 months ago (2016-08-01 14:35:01 UTC) #3
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-01 14:37:48 UTC) #5
Yang
lgtm
4 years, 4 months ago (2016-08-01 14:58:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196263002/1
4 years, 4 months ago (2016-08-01 15:24:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 15:26:34 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 15:27:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df4196db97f3ea6add3eee7fe4e359125d9cca82
Cr-Commit-Position: refs/heads/master@{#38216}

Powered by Google App Engine
This is Rietveld 408576698