Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2196223002:
[test] Add testing variant aliases. (Closed)
|
Created:
4 years, 4 months ago by Michael Achenbach Modified:
4 years, 4 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Add testing variant aliases.
This introduces aliases for testing variants that can be
combined with other variant names. E.g. --variants=dev,foo
would run the three developer default variants and variant
foo.
We'll have three stages: "dev" for variants to be run by
default on developer workstations, "more" for additional
variants, executed on all bots, "extra" for additional
variants executed on a subset of bots (e.g. not on very slow
or otherwise resource-limited bots).
BUG=v8:5238
NOTRY=true
Committed: https://crrev.com/6c1d6c9f815fc218f4f886a00cdd9dfa4e8e86e3
Cr-Commit-Position: refs/heads/master@{#38214}
Patch Set 1 #Patch Set 2 : [test] Add testing variant aliases. #
Total comments: 3
Patch Set 3 : Review #Messages
Total messages: 20 (12 generated)
Description was changed from ========== [test] Add testing variant aliases. BUG= ========== to ========== [test] Add testing variant aliases. BUG=v8:5238 ==========
Description was changed from ========== [test] Add testing variant aliases. BUG=v8:5238 ========== to ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "exhaustive" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 ==========
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, mstarzinger@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL https://codereview.chromium.org/2196223002/diff/20001/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2196223002/diff/20001/tools/run-tests.py#newc... tools/run-tests.py:129: "more": MORE_VARIANTS, The "more" set is going to deprecate the current --exhaustive-variants flag.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with comment. https://codereview.chromium.org/2196223002/diff/20001/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2196223002/diff/20001/tools/run-tests.py#newc... tools/run-tests.py:131: "exhaustive": [], This seems surprising. Did you mean s/[]/EXHAUSTIVE_VARIANTS/?
https://codereview.chromium.org/2196223002/diff/20001/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2196223002/diff/20001/tools/run-tests.py#newc... tools/run-tests.py:131: "exhaustive": [], On 2016/08/01 13:44:56, Jakob wrote: > This seems surprising. Did you mean s/[]/EXHAUSTIVE_VARIANTS/? No, as commented above, the "more" entry is going to deprecate exhaustive variants. The former "exhaustive variants" were never really exhaustive. They were what the bots ran but the developers don't. But there are even more variants, which we now call exhaustive. The set is now empty to allow transitioning variants there in separate CLs. E.g. --nocrankshaft is going to move there, and probably the new variant --ignition-staging --turbo --always-opt.
Description was changed from ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "exhaustive" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 ========== to ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "extra" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 ==========
Rename in patch 3
Description was changed from ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "extra" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 ========== to ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "extra" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 NOTRY=true ==========
Still LGTM
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "extra" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 NOTRY=true ========== to ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "extra" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "extra" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 NOTRY=true ========== to ========== [test] Add testing variant aliases. This introduces aliases for testing variants that can be combined with other variant names. E.g. --variants=dev,foo would run the three developer default variants and variant foo. We'll have three stages: "dev" for variants to be run by default on developer workstations, "more" for additional variants, executed on all bots, "extra" for additional variants executed on a subset of bots (e.g. not on very slow or otherwise resource-limited bots). BUG=v8:5238 NOTRY=true Committed: https://crrev.com/6c1d6c9f815fc218f4f886a00cdd9dfa4e8e86e3 Cr-Commit-Position: refs/heads/master@{#38214} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6c1d6c9f815fc218f4f886a00cdd9dfa4e8e86e3 Cr-Commit-Position: refs/heads/master@{#38214} |
