[Mac] The infobar's top arrow should be hidden while the omnibox popup is shown

chrome/browser/ui/cocoa/browser_window_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 
 // A class acting as the Objective-C controller for the Browser
 // object. Handles interactions between Cocoa and the cross-platform
 // code. Each window has a single toolbar and, by virtue of being a
@@ skipping 46 matching lines @@
 @class TranslateBubbleController;
 
 namespace content {
 class WebContents;
 }
 
 namespace extensions {
 class Command;
 }
 
+namespace {
+class OmniboxPopupModelObserverBridge;
+}
+
 @interface BrowserWindowController
     : TabWindowController<BookmarkBarControllerDelegate,
                           ViewResizer,
                           TabStripControllerDelegate> {
  @private
   // The ordering of these members is important as it determines the order in
   // which they are destroyed. |browser_| needs to be destroyed last as most of
   // the other objects hold weak references to it or things it owns
   // (tab/toolbar/bookmark models, profiles, etc).
   std::unique_ptr<Browser> browser_;
@@ skipping 117 matching lines @@
 
   // If this ivar is set to YES, layoutSubviews calls will be ignored. This is
   // used in fullscreen transition to prevent spurious resize messages from
   // being sent to the renderer, which causes the transition to be janky.
   BOOL blockLayoutSubviews_;
 
   // The Extension Command Registry used to determine which keyboard events to
   // handle.
   std::unique_ptr<ExtensionKeybindingRegistryCocoa>
       extension_keybinding_registry_;
+
+  // Observes whether the omnibox popup is shown or hidden.
+  std::unique_ptr<OmniboxPopupModelObserverBridge>
+      omnibox_popup_model_observer_bridge_;

[Robert Sesek, 2016/08/04 17:13:40]

naming: use camelCase since this is an ObjC ivar (the variable on line 207 is
wrongly named).

[Sungmann Cho, 2016/08/04 17:42:26]

Done.

 }
 
 // A convenience class method which gets the |BrowserWindowController| for a
 // given window. This method returns nil if no window in the chain has a BWC.
 + (BrowserWindowController*)browserWindowControllerForWindow:(NSWindow*)window;
 
 // A convenience class method which gets the |BrowserWindowController| for a
 // given view.  This is the controller for the window containing |view|, if it
 // is a BWC, or the first controller in the parent-window chain that is a
 // BWC. This method returns nil if no window in the chain has a BWC.
@@ skipping 422 matching lines @@
 // Returns the fullscreen toolbar controller.
 - (FullscreenToolbarController*)fullscreenToolbarController;
 
 // Sets the fullscreen toolbar controller.
 - (void)setFullscreenToolbarController:(FullscreenToolbarController*)controller;
 
 @end  // @interface BrowserWindowController (TestingAPI)
 
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_