Expanded GnomeKeyringLoader macros

Get rid of GnomeKeyringLoader macros

BUG=602624
Committed: https://crrev.com/469b0eeb77b21342dc864ab2117d07ce0c2c950c
Cr-Commit-Position: refs/heads/master@{#408965}

[cfroussios, 2016-08-01 08:12:20]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 08:12:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-01 08:29:04]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 08:29:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-01 08:46:18]

cfroussios@chromium.org changed reviewers:
+ vasilii@chromium.org

[cfroussios, 2016-08-01 08:46:19]

Hi! Can you review this change? Thanks!

[commit-bot: I haz the power, 2016-08-01 09:10:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 09:10:42]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-08-01 09:51:27]

Change the description to "Get rid of GnomeKeyringLoader macros"

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_gnome_x.cc (right):

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.cc:45:
typeof(&::gnome_keyring_is_available)
decltype

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.cc:68:
reinterpret_cast<void**>(&gnome_keyring_is_available)},
Will static_cast work here?

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_gnome_x.h (right):

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.h:46: static
decltype(&::gnome_keyring_is_available) gnome_keyring_is_available;
Do you deliberately reuse the same names?

[cfroussios, 2016-08-01 10:47:50]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 10:48:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-01 10:50:48]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-08-01 10:51:22]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[cfroussios, 2016-08-01 10:51:50]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 10:52:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-01 10:54:21]

Description was changed from

==========
Expanded GnomeKeyringLoader macros

BUG=602624
==========

to

==========
Get rid of GnomeKeyringLoader macros

BUG=602624
==========

[cfroussios, 2016-08-01 10:54:53]

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_gnome_x.cc (right):

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.cc:45:
typeof(&::gnome_keyring_is_available)
On 2016/08/01 09:51:26, vasilii wrote:
> decltype

Done.

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.cc:68:
reinterpret_cast<void**>(&gnome_keyring_is_available)},
On 2016/08/01 09:51:26, vasilii wrote:
> Will static_cast work here?

The compiler does not allow it.

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_gnome_x.h (right):

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.h:46: static
decltype(&::gnome_keyring_is_available) gnome_keyring_is_available;
On 2016/08/01 09:51:26, vasilii wrote:
> Do you deliberately reuse the same names? 

That's the names that the macros would produce. Are you suggesting that we
should rename the functions? We could definitely drop the prefix.

[commit-bot: I haz the power, 2016-08-01 11:29:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 11:29:47]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-08-01 11:46:38]

lgtm

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_gnome_x.h (right):

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.h:46: static
decltype(&::gnome_keyring_is_available) gnome_keyring_is_available;
On 2016/08/01 10:54:52, cfroussios wrote:
> On 2016/08/01 09:51:26, vasilii wrote:
> > Do you deliberately reuse the same names? 
> 
> That's the names that the macros would produce. Are you suggesting that we
> should rename the functions? We could definitely drop the prefix.

I'd use gnome_keyring_is_available_ptr. I'm totally fine with dropping the
prefix too.

[cfroussios, 2016-08-01 14:14:39]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 14:14:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-01 14:26:45]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 14:26:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-01 14:31:04]

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_gnome_x.h (right):

https://codereview.chromium.org/2196193002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_gnome_x.h:46: static
decltype(&::gnome_keyring_is_available) gnome_keyring_is_available;
On 2016/08/01 11:46:37, vasilii wrote:
> On 2016/08/01 10:54:52, cfroussios wrote:
> > On 2016/08/01 09:51:26, vasilii wrote:
> > > Do you deliberately reuse the same names? 
> > 
> > That's the names that the macros would produce. Are you suggesting that we
> > should rename the functions? We could definitely drop the prefix.
> 
> I'd use gnome_keyring_is_available_ptr. I'm totally fine with dropping the
> prefix too.

I used ptr. I didn't get rid of the prefix, because then some functions, e.g.
GnomeKeyringLoader::is_available_ptr(), could be read as if querying the state
of the loader, instead of the library.

[vasilii, 2016-08-01 14:38:13]

lgtm

[commit-bot: I haz the power, 2016-08-01 15:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 15:03:47]

Dry run: This issue passed the CQ dry run.

[cfroussios, 2016-08-01 15:05:18]

The CQ bit was checked by cfroussios@chromium.org

[commit-bot: I haz the power, 2016-08-01 15:05:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 15:08:39]

Description was changed from

==========
Get rid of GnomeKeyringLoader macros

BUG=602624
==========

to

==========
Get rid of GnomeKeyringLoader macros

BUG=602624
==========

[commit-bot: I haz the power, 2016-08-01 15:08:41]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-08-01 15:10:02]

Description was changed from

==========
Get rid of GnomeKeyringLoader macros

BUG=602624
==========

to

==========
Get rid of GnomeKeyringLoader macros

BUG=602624

Committed: https://crrev.com/469b0eeb77b21342dc864ab2117d07ce0c2c950c
Cr-Commit-Position: refs/heads/master@{#408965}
==========

[commit-bot: I haz the power, 2016-08-01 15:10:03]

Patchset 5 (id:??) landed as
https://crrev.com/469b0eeb77b21342dc864ab2117d07ce0c2c950c
Cr-Commit-Position: refs/heads/master@{#408965}