Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2196143002: Revert of [Presentation API] Convert presentation.mojom to new wrapper types. (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mlamouri+watch-content_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #5 id:80001 of https://codereview.chromium.org/2181163003/ ) Reason for revert: Suspect (not the first) for widespread NaCl test failures since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504 Errors like [4224:3200:0729/162247:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096) ... Actual: "Plugin crashed. 'NaCl module crashed'" Wasn't r408782 or r408787. Running out of candidates.. Original issue's description: > [Presentation API] Convert presentation.mojom to new wrapper types. > > This converts presentation.mojom to use the new (std::) Mojo wrapper types: > mojo::String => std::string > mojo::Array => std::vector > > No behavior changes should ensue. > > Optional values are represented as base::Optional<Foo> with the new wrapper > types requiring some additional changes. > > This work will simplify further changes for crbug.com/627655. > > BUG=627655 > > Committed: https://crrev.com/59e7b40948030815a49af887b922b370ba048b8b > Cr-Commit-Position: refs/heads/master@{#408781} TBR=dcheng@chromium.org,imcheng@chromium.org,mfoltz@chromium.org NOTRY=true BUG=627655 Committed: https://crrev.com/43c746be32b2bfce5c3fd654894e4b7f7bf6387f Cr-Commit-Position: refs/heads/master@{#408905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -169 lines) Patch
M content/browser/presentation/presentation_service_impl.h View 2 chunks +14 lines, -13 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 9 chunks +49 lines, -50 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 14 chunks +46 lines, -31 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 6 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 5 chunks +1 line, -50 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tapted
Created Revert of [Presentation API] Convert presentation.mojom to new wrapper types.
4 years, 4 months ago (2016-08-01 03:12:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196143002/1
4 years, 4 months ago (2016-08-01 03:12:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196143002/1
4 years, 4 months ago (2016-08-01 03:23:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 03:31:20 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43c746be32b2bfce5c3fd654894e4b7f7bf6387f Cr-Commit-Position: refs/heads/master@{#408905}
4 years, 4 months ago (2016-08-01 03:33:31 UTC) #11
tapted
4 years, 4 months ago (2016-08-01 04:50:32 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2197053002/ by tapted@chromium.org.

The reason for reverting is: Didn't work. NaCl still crashing. Sadness :(.

Powered by Google App Engine
This is Rietveld 408576698