DescriptionRevert of Pass per-frame task runners to Workers (when possible) (patchset #5 id:100001 of https://codereview.chromium.org/2163983004/ )
Reason for revert:
Suspected for multiple failures in `WebKit Linux Leak` since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21436
e.g.
http/tests/serviceworker/foreign-fetch-workers.html
fast/workers/worker-document-leak.html
+ 7 more
errors like
10:21:04.195 21200 worker/1 http/tests/serviceworker/foreign-fetch-workers.html leaked
10:21:04.196 21133 [14636/39978] http/tests/serviceworker/foreign-fetch-workers.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,28],"numberOfLiveResources":[0,2]}))
10:21:04.195 21200 worker/1 http/tests/serviceworker/foreign-fetch-workers.html failed:
10:21:04.195 21200 worker/1 leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,28],"numberOfLiveResources":[0,2]})
Original issue's description:
> Pass per-frame task runners to Workers (when possible)
>
> - For in-process workers (i.e. dedicated/compositor workers): always use
> the associated document's task runners
> - For out-of-process workers (i.e. service/shared workers): keep using the
> default task runner of the main thread, but via TaskRunnerHelper so
> we could still start using different task runners for different tasks
> (e.g. loading vs timer) if we want.
>
> BUG=627034
>
> Committed: https://crrev.com/66b07a326160fed57046fbb454f424a302d4cc6b
> Cr-Commit-Position: refs/heads/master@{#408652}
TBR=skyostil@chromium.org,hiroshige@chromium.org,haraken@chromium.org,nhiroki@chromium.org,kinuko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627034
Patch Set 1 #Patch Set 2 : rebase for conflict with r408886 #Patch Set 3 : fix merge #Patch Set 4 : ngh #Patch Set 5 : crud #Messages
Total messages: 29 (16 generated)
|