Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2196133002: Revert of Pass per-frame task runners to Workers (when possible) (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
CC:
chromium-reviews, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass per-frame task runners to Workers (when possible) (patchset #5 id:100001 of https://codereview.chromium.org/2163983004/ ) Reason for revert: Suspected for multiple failures in `WebKit Linux Leak` since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21436 e.g. http/tests/serviceworker/foreign-fetch-workers.html fast/workers/worker-document-leak.html + 7 more errors like 10:21:04.195 21200 worker/1 http/tests/serviceworker/foreign-fetch-workers.html leaked 10:21:04.196 21133 [14636/39978] http/tests/serviceworker/foreign-fetch-workers.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,28],"numberOfLiveResources":[0,2]})) 10:21:04.195 21200 worker/1 http/tests/serviceworker/foreign-fetch-workers.html failed: 10:21:04.195 21200 worker/1 leak detected: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,28],"numberOfLiveResources":[0,2]}) Original issue's description: > Pass per-frame task runners to Workers (when possible) > > - For in-process workers (i.e. dedicated/compositor workers): always use > the associated document's task runners > - For out-of-process workers (i.e. service/shared workers): keep using the > default task runner of the main thread, but via TaskRunnerHelper so > we could still start using different task runners for different tasks > (e.g. loading vs timer) if we want. > > BUG=627034 > > Committed: https://crrev.com/66b07a326160fed57046fbb454f424a302d4cc6b > Cr-Commit-Position: refs/heads/master@{#408652} TBR=skyostil@chromium.org,hiroshige@chromium.org,haraken@chromium.org,nhiroki@chromium.org,kinuko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=627034

Patch Set 1 #

Patch Set 2 : rebase for conflict with r408886 #

Patch Set 3 : fix merge #

Patch Set 4 : ngh #

Patch Set 5 : crud #

Messages

Total messages: 29 (16 generated)
tapted
Created Revert of Pass per-frame task runners to Workers (when possible)
4 years, 4 months ago (2016-08-01 02:43:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196133002/1
4 years, 4 months ago (2016-08-01 02:43:37 UTC) #3
haraken
LGTM
4 years, 4 months ago (2016-08-01 02:44:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/44020) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-01 02:45:08 UTC) #6
tapted
On 2016/08/01 02:45:08, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-01 02:47:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196133002/60003
4 years, 4 months ago (2016-08-01 02:56:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/104534)
4 years, 4 months ago (2016-08-01 03:04:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196133002/190001
4 years, 4 months ago (2016-08-01 05:32:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/104563)
4 years, 4 months ago (2016-08-01 05:40:38 UTC) #17
tapted
Wow - so this CL (r408652) conflicts with r408863 AND r408886 (yuck). Resolving the conflicts ...
4 years, 4 months ago (2016-08-01 06:55:00 UTC) #24
tzik
On 2016/08/01 06:55:00, tapted wrote: > Wow - so this CL (r408652) conflicts with r408863 ...
4 years, 4 months ago (2016-08-01 07:20:51 UTC) #27
haraken
On 2016/08/01 07:20:51, tzik wrote: > On 2016/08/01 06:55:00, tapted wrote: > > Wow - ...
4 years, 4 months ago (2016-08-01 07:22:13 UTC) #28
tapted
4 years, 4 months ago (2016-08-01 07:22:43 UTC) #29
On 2016/08/01 07:20:51, tzik wrote:
> On 2016/08/01 06:55:00, tapted wrote:
> > Wow - so this CL (r408652) conflicts with r408863 AND r408886 (yuck).
> Resolving
> > the conflicts with r408886 is mechanical, but r408863 is not. Trying a dry
run
> > with patchset 5 now, but I don't really like it. kinuko@ are you around to
> take
> > this over and possibly work on a fix for the leaks, or revert the CL?
> 
> Another try for revert is getting green. Can I land it?
> https://codereview.chromium.org/2199633002/

awesome: go for it :)

Powered by Google App Engine
This is Rietveld 408576698