Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219613003: Add global fontconfig lock. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
bungeman-skia, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add global fontconfig lock. BUG=skia:2255, skia:1497 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13998

Patch Set 1 #

Total comments: 2

Patch Set 2 : live version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M src/fonts/SkFontMgr_fontconfig.cpp View 1 6 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mtklein
I am unable to get ASAN to complain like it does at head, so I'm ...
6 years, 8 months ago (2014-03-31 16:50:29 UTC) #1
bungeman-skia
https://codereview.chromium.org/219613003/diff/1/src/fonts/SkFontMgr_fontconfig.cpp File src/fonts/SkFontMgr_fontconfig.cpp (right): https://codereview.chromium.org/219613003/diff/1/src/fonts/SkFontMgr_fontconfig.cpp#newcode21 src/fonts/SkFontMgr_fontconfig.cpp:21: #if FC_VERSION < 21091 I'm not sure that it ...
6 years, 8 months ago (2014-03-31 17:25:51 UTC) #2
mtklein
https://codereview.chromium.org/219613003/diff/1/src/fonts/SkFontMgr_fontconfig.cpp File src/fonts/SkFontMgr_fontconfig.cpp (right): https://codereview.chromium.org/219613003/diff/1/src/fonts/SkFontMgr_fontconfig.cpp#newcode21 src/fonts/SkFontMgr_fontconfig.cpp:21: #if FC_VERSION < 21091 On 2014/03/31 17:25:51, bungeman1 wrote: ...
6 years, 8 months ago (2014-03-31 17:37:36 UTC) #3
bungeman-skia
lgtm
6 years, 8 months ago (2014-03-31 17:39:26 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-03-31 17:41:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/219613003/20001
6 years, 8 months ago (2014-03-31 17:41:35 UTC) #6
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 8 months ago (2014-03-31 18:01:04 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-03-31 18:01:04 UTC) #8
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 8 months ago (2014-03-31 18:40:38 UTC) #9
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-03-31 18:41:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/219613003/20001
6 years, 8 months ago (2014-03-31 18:41:05 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 18:41:36 UTC) #12
Message was sent while issue was closed. 
Change committed as 13998

Powered by Google App Engine
This is Rietveld 408576698