chrome/common/extensions/api/events.json - Issue 219613002: Add support for matching query parameters in URLMatcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/events.json

Issue 219613002: Add support for matching query parameters in URLMatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes the review comments from Dominic and Joao Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/events.json

diff --git a/chrome/common/extensions/api/events.json b/chrome/common/extensions/api/events.json

index b09dba7582e67746c43c294f0b8e3b486537a9db..0a474bdbcee797b3acdd482d325b26d6c1579af3 100644

--- a/chrome/common/extensions/api/events.json

+++ b/chrome/common/extensions/api/events.json

@@ -262,7 +262,7 @@

"queryContains": {

"type": "string",

- "description": "Matches if the query segment of the URL contains a specified string.",

+ "description": "Matches if the query segment of the URL contains a specified set of key value pairs with '&' as the delimiter. Query starting with a partial key or value is not supported, i.e., the string should start with a full key optionally followed by an equal sign and a value.",

battre 2014/04/01 14:46:07 s/Query starting/A queryContains filter starting/

"optional": true

"queryEquals": {

« no previous file with comments | « no previous file | components/url_matcher/url_matcher.cc » ('j') | no next file with comments »