Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2196103003: Revert of Speculative fix for perf test performance regressions. (Closed)

Created:
4 years, 4 months ago by Guido Urdaneta
Modified:
4 years, 4 months ago
Reviewers:
waffles, Will Harris
CC:
chromium-reviews, RyanS
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Speculative fix for perf test performance regressions. (patchset #1 id:1 of https://codereview.chromium.org/2190083002/ ) Reason for revert: Speculative revert to see if that fixes the WebRTC Win7 Tester bot. See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/28171 Sample error logs: [ RUN ] PPAPINaClPNaClTest.MediaStreamVideoTrack [4788:5076:0729/174935:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart [5744:3076:0729/174935:ERROR:dxva_video_decode_accelerator_win.cc(273)] EGL_EXT_device_query missing [5744:3076:0729/174935:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 273 [6048:3772:0729/174935:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [4788:4472:0729/174936:WARNING:embedded_test_server.cc(202)] Request not handled. Returning 404: /favicon.ico [4788:4168:0729/174936:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096) [4788:5076:0729/174936:INFO:CONSOLE(0)] "NativeClient: NaCl module crashed", source: http://127.0.0.1:50824/test_case.html?mode=nacl_pnacl&testcase=MediaStreamVideoTrack (0) e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_test.cc(249): error: Value of: handler.message().c_str() Actual: "Plugin crashed. 'NaCl module crashed'" Expected: "PASS" [5744:3300:0729/174936:ERROR:node_controller.cc(1099)] Could not be introduced to peer 71198AAF592CFFC1.CFEE94F16E49B4BD [4788:5076:0729/174937:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] PPAPINaClPNaClTest.MediaStreamVideoTrack, where TypeParam = and GetParam() = (2255 ms) [98/98] PPAPINaClPNaClTest.MediaStreamVideoTrack (2556 ms) Retrying 1 test (retry #3) [ RUN ] PPAPINaClPNaClTest.MediaStreamVideoTrack [5628:4292:0729/174937:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart [1440:4176:0729/174937:ERROR:dxva_video_decode_accelerator_win.cc(273)] EGL_EXT_device_query missing [1440:4176:0729/174937:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 273 [4792:5844:0729/174937:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [5628:6016:0729/174938:WARNING:embedded_test_server.cc(202)] Request not handled. Returning 404: /favicon.ico [5628:6104:0729/174939:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096) [5628:4292:0729/174939:INFO:CONSOLE(0)] "NativeClient: NaCl module crashed", source: http://127.0.0.1:50830/test_case.html?mode=nacl_pnacl&testcase=MediaStreamVideoTrack (0) e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_test.cc(249): error: Value of: handler.message().c_str() Actual: "Plugin crashed. 'NaCl module crashed'" Expected: "PASS" [1440:1012:0729/174939:ERROR:node_controller.cc(1099)] Could not be introduced to peer 326301B2EC2EF45.56A4474DAFD5DD29 [5628:4292:0729/174939:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] PPAPINaClPNaClTest.MediaStreamVideoTrack, where TypeParam = and GetParam() = (2243 ms) [99/99] PPAPINaClPNaClTest.MediaStreamVideoTrack (2537 ms) 1 test failed: PPAPINaClPNaClTest.MediaStreamVideoTrack (e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_browsertest.cc:1164) Will reland if the revert doesn't fix the issue. Original issue's description: > Speculative fix for perf test performance regressions. > > BUG=623804 > > Committed: https://crrev.com/1eadbdccdb0dee6fe9e169ac374bfa6c1ad9d03d > Cr-Commit-Position: refs/heads/master@{#408789} TBR=wfh@chromium.org,waffles@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623804 Committed: https://crrev.com/01bd53dba19f1df9dd002a15c87a1ea180c1ffbb Cr-Commit-Position: refs/heads/master@{#408956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Guido Urdaneta
Created Revert of Speculative fix for perf test performance regressions.
4 years, 4 months ago (2016-08-01 13:26:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196103003/1
4 years, 4 months ago (2016-08-01 13:27:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 14:11:00 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/01bd53dba19f1df9dd002a15c87a1ea180c1ffbb Cr-Commit-Position: refs/heads/master@{#408956}
4 years, 4 months ago (2016-08-01 14:13:00 UTC) #7
Guido Urdaneta
4 years, 4 months ago (2016-08-01 15:38:17 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2195373003/ by guidou@chromium.org.

The reason for reverting is: The revert did not fix the issue it was suspect of
causing..

Powered by Google App Engine
This is Rietveld 408576698