auth: Minor fixes in OpenID login flow.

auth: Minor fixes in OpenID login flow.

In particular:
  * Fix typo in code that reports missing 'state' parameter error.
  * Always show account chooser, even if there's only one account (fixes some
    annoying silent redirects).
  * Stricter validation of redirect URLs in /login and /logout.

R=nodir@chromium.org
BUG=

Committed: https://github.com/luci/luci-py/commit/777aeadd52d6a8af4e60b884109102bd8757696b

[nodir, 2016-07-30 20:04:14]

lgtm

https://codereview.chromium.org/2196043002/diff/1/appengine/components/compon...
File appengine/components/components/auth/openid.py (left):

https://codereview.chromium.org/2196043002/diff/1/appengine/components/compon...
appengine/components/components/auth/openid.py:362: self.abort(400,
detai='Missing "state" parameter')
Yay Python

https://codereview.chromium.org/2196043002/diff/1/appengine/components/compon...
File appengine/components/components/auth/openid.py (right):

https://codereview.chromium.org/2196043002/diff/1/appengine/components/compon...
appengine/components/components/auth/openid.py:578: # Get rid of '//', '.', '..'
in the path.
posixpath.normpath?

[Vadim Sh., 2016-07-30 20:09:51]

https://codereview.chromium.org/2196043002/diff/1/appengine/components/compon...
File appengine/components/components/auth/openid.py (right):

https://codereview.chromium.org/2196043002/diff/1/appengine/components/compon...
appengine/components/components/auth/openid.py:578: # Get rid of '//', '.', '..'
in the path.
On 2016/07/30 20:04:14, nodir wrote:
> posixpath.normpath?

It treats leading '//' differently, based on the source code.

[Vadim Sh., 2016-07-31 18:09:18]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2016-07-31 18:09:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-31 18:11:42]

Description was changed from

==========
auth: Minor fixes in OpenID login flow.

In particular:
  * Fix typo in code that reports missing 'state' parameter error.
  * Always show account chooser, even if there's only one account (fixes some
    annoying silent redirects).
  * Stricter validation of redirect URLs in /login and /logout.

R=nodir@chromium.org
BUG=
==========

to

==========
auth: Minor fixes in OpenID login flow.

In particular:
  * Fix typo in code that reports missing 'state' parameter error.
  * Always show account chooser, even if there's only one account (fixes some
    annoying silent redirects).
  * Stricter validation of redirect URLs in /login and /logout.

R=nodir@chromium.org
BUG=

Committed:
https://github.com/luci/luci-py/commit/777aeadd52d6a8af4e60b884109102bd8757696b
==========

[commit-bot: I haz the power, 2016-07-31 18:11:43]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/777aeadd52d6a8af4e60b884109102bd8757696b