Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2011)

Unified Diff: extensions/browser/extension_prefs.cc

Issue 219593002: Add unit test for the Settings API Bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_prefs.cc
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc
index 24f7e5831ba809aba5fac2d5fb2aea243ecfef5e..53d800ca0d56ba17f495ffad418172959d52efba 100644
--- a/extensions/browser/extension_prefs.cc
+++ b/extensions/browser/extension_prefs.cc
@@ -1897,10 +1897,8 @@ void ExtensionPrefs::SetInstallSignature(
std::string ExtensionPrefs::GetInstallParam(
const std::string& extension_id) const {
const base::DictionaryValue* extension = GetExtensionPref(extension_id);
- if (!extension) {
- NOTREACHED();
+ if (!extension) // Expected during unit testing.
return std::string();
- }
std::string install_parameter;
if (!extension->GetString(kPrefInstallParam, &install_parameter))
return std::string();

Powered by Google App Engine
This is Rietveld 408576698