Add unit test for the Settings API Bubble.

chrome/browser/extensions/settings_api_bubble_controller.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/settings_api_bubble_controller.h"
 
 #include "base/metrics/histogram.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/settings_api_helpers.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler.h"
 #include "chrome/common/url_constants.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 67 matching lines @@
   ExtensionRegistry* registry = ExtensionRegistry::Get(profile_);
   const extensions::Extension* extension =
       registry->GetExtensionById(extension_id, ExtensionRegistry::ENABLED);
   if (!extension)
     return false;  // The extension provided is no longer enabled.
 
   extensions::ExtensionPrefs* prefs = extensions::ExtensionPrefs::Get(profile_);
   if (prefs->HasSettingsApiBubbleBeenAcknowledged(extension_id))
     return false;
 
-  const SettingsOverrides* settings = SettingsOverrides::Get(extension);
-  if (!settings)
-    return false;
-
-  bool should_include = false;
+  const extensions::Extension* override = NULL;
   switch (type_) {
     case extensions::BUBBLE_TYPE_HOME_PAGE:
-      should_include = settings->homepage != NULL;
+      override = extensions::OverridesHomepage(profile_, NULL);
       break;
     case extensions::BUBBLE_TYPE_STARTUP_PAGES:
-      should_include = !settings->startup_pages.empty();
+      override = extensions::OverridesStartupPages(profile_, NULL);
       break;
     case extensions::BUBBLE_TYPE_SEARCH_ENGINE:
-      should_include = settings->search_engine != NULL;
+      override = extensions::OverridesSearchEngine(profile_, NULL);
       break;
   }
 
-  if (should_include && extension_id_ != extension_id) {
-    DCHECK(extension_id_.empty());
-    extension_id_ = extension_id;
-  }
-  return should_include;
+  if (!override || override->id() != extension->id())
+    return false;
+
+  extension_id_ = extension_id;
+  return true;
 }
 
 void SettingsApiBubbleDelegate::AcknowledgeExtension(
     const std::string& extension_id,
     ExtensionMessageBubbleController::BubbleAction user_action) {
-  extensions::ExtensionPrefs* prefs = extensions::ExtensionPrefs::Get(profile_);
-  prefs->SetSettingsApiBubbleBeenAcknowledged(extension_id, true);
+  if (user_action != ExtensionMessageBubbleController::ACTION_EXECUTE) {
+    extensions::ExtensionPrefs* prefs =
+        extensions::ExtensionPrefs::Get(profile_);
+    prefs->SetSettingsApiBubbleBeenAcknowledged(extension_id, true);
+  }
 }
 
 void SettingsApiBubbleDelegate::PerformAction(
     const extensions::ExtensionIdList& list) {
   for (size_t i = 0; i < list.size(); ++i) {
     service_->DisableExtension(list[i],
                                extensions::Extension::DISABLE_USER_ACTION);
   }
 }
 
@@ skipping 156 matching lines @@
   return true;
 }
 
 bool SettingsApiBubbleController::CloseOnDeactivate() {
   // Startup bubbles tend to get lost in the focus storm that happens on
   // startup. Other types should dismiss on focus loss.
   return type_ != BUBBLE_TYPE_STARTUP_PAGES;
 }
 
 }  // namespace extensions