Add unit test for the Settings API Bubble.

Add unit test for the Settings API Bubble.

Refactored the helper functions into views-specific code and rest (so that the non-views code can be used in more places).

Fixed a bug where if you have two extensions simultaneously overwriting settings, the bubble now knows which one is active.

Also prevent the bubble from writing the suppress flag when the user choses to disable the extension (that way they get the bubble again if the extension becomes enabled for some reason).

BUG=356204
R=sky@chromium.org, yoz@chromium.org
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261438

[Finnur, 2014-04-01 21:30:40]

Yoyo, this is a follow-up test that I didn't have time to write for the Settings
API bubbles.

TBR-ing Scott for re-factoring some of my non-Views specific code out of Views
files.

[sky, 2014-04-01 22:45:44]

LGTM

[Finnur, 2014-04-02 20:23:00]

Yoyo: ping.

[Yoyo Zhou, 2014-04-02 20:36:25]

LGTM

https://codereview.chromium.org/219593002/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
(right):

https://codereview.chromium.org/219593002/diff/80001/chrome/browser/extension...
chrome/browser/extensions/extension_message_bubble_controller_unittest.cc:183:
CreateExtension(
Can you use ExtensionBuilder and DictionaryBuilder here? Seems like you can do
better than passing a JSON string around for the manifests.

https://codereview.chromium.org/219593002/diff/80001/chrome/browser/extension...
chrome/browser/extensions/extension_message_bubble_controller_unittest.cc:466:
// We deliberately skip testing the search engine since it relies on
IMHO this would be easier to read if
- the for loop was ++i
- this comment was on the search engine override case, and it just had continue;

[Finnur, 2014-04-03 15:46:12]

Great suggestions. Implemented both. Checking in.

[Finnur, 2014-04-03 16:23:16]

Committed patchset #8 manually as r261438 (presubmit successful).